From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hyong-Youb Kim Date: Sat, 21 Mar 2015 07:08:00 +0000 Subject: Re: [PATCH v1 21/47] ethernet: myri10ge: use arch_phys_wc_add() Message-Id: <20150321070759.GB8766@gtest01.arcus> List-Id: References: <1426893517-2511-1-git-send-email-mcgrof@do-not-panic.com> <1426893517-2511-22-git-send-email-mcgrof@do-not-panic.com> In-Reply-To: <1426893517-2511-22-git-send-email-mcgrof@do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Luis R. Rodriguez" Cc: luto@amacapital.net, mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, jgross@suse.com, JBeulich@suse.com, bp@suse.de, suresh.b.siddha@intel.com, venkatesh.pallipadi@intel.com, airlied@redhat.com, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org, "Luis R. Rodriguez" , Ingo Molnar , Daniel Vetter , Hyong-Youb Kim , netdev@vger.kernel.org, Antonino Daplas , Jean-Christophe Plagniol-Villard , Tomi Valkeinen On Fri, Mar 20, 2015 at 04:18:11PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already uses ioremap_wc() on the same range > so when write-combining is available that will be used > instead. > [...] > --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c [...] > @@ -1984,7 +1979,6 @@ myri10ge_get_ethtool_stats(struct net_device *netdev, > data[i] = ((u64 *)&link_stats)[i]; > > data[i++] = (unsigned int)mgp->tx_boundary; > - data[i++] = (unsigned int)mgp->wc_enabled; > data[i++] = (unsigned int)mgp->pdev->irq; > data[i++] = (unsigned int)mgp->msi_enabled; > data[i++] = (unsigned int)mgp->msix_enabled; You would have to delete "WC from myri10ge_gstrings_main_stats too. Something like below. Thanks. @@ -1905,7 +1905,7 @@ static const char myri10ge_gstrings_main_stats[][ETH_GSTRING_LEN] = { "tx_aborted_errors", "tx_carrier_errors", "tx_fifo_errors", "tx_heartbeat_errors", "tx_window_errors", /* device-specific stats */ - "tx_boundary", "WC", "irq", "MSI", "MSIX", + "tx_boundary", "irq", "MSI", "MSIX", "read_dma_bw_MBs", "write_dma_bw_MBs", "read_write_dma_bw_MBs", "serial_number", "watchdog_resets", #ifdef CONFIG_MYRI10GE_DCA