From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 01/13] staging: sm750: Reintend
Date: Mon, 23 Mar 2015 11:17:27 +0000 [thread overview]
Message-ID: <20150323111727.GC10964@mwanda> (raw)
In-Reply-To: <20150322230807.GA16817@x230-arch.club.entropia.de>
On Mon, Mar 23, 2015 at 12:08:07AM +0100, Michel von Czettritz wrote:
> The reintend fixes the
Spelling. re-indent.
> typedef void (*PROC_SPEC_SETUP)(struct lynx_share*,char *);
> @@ -76,54 +76,54 @@ static inline void myspin_unlock(spinlock_t * sl){
> static const struct fb_videomode lynx750_ext[] = {
> /* 1024x600-60 VESA [1.71:1] */
> {NULL, 60, 1024, 600, 20423, 144, 40, 18, 1, 104, 3,
> - FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED},
> + FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED},
>
Do it like this:
{NULL, 60, 1024, 600, 20423, 144, 40, 18, 1, 104, 3,
FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED},
> @@ -141,8 +141,8 @@ static int lynxfb_ops_cursor(struct fb_info* info,struct fb_cursor* fbcursor)
> cursor = &crtc->cursor;
>
> if(fbcursor->image.width > cursor->maxW ||
> - fbcursor->image.height > cursor->maxH ||
> - fbcursor->image.depth > 1){
> + fbcursor->image.height > cursor->maxH ||
> + fbcursor->image.depth > 1){
This should be:
if (fbcursor->image.width > cursor->maxW ||
fbcursor->image.height > cursor->maxH ||
fbcursor->image.depth > 1)
return -ENXIO;
The new indenting is whacky.
> return -ENXIO;
> }
>
> @@ -153,19 +153,19 @@ static int lynxfb_ops_cursor(struct fb_info* info,struct fb_cursor* fbcursor)
>
> if(fbcursor->set & FB_CUR_SETPOS){
> cursor->setPos(cursor,fbcursor->image.dx - info->var.xoffset,
> - fbcursor->image.dy - info->var.yoffset);
> + fbcursor->image.dy - info->var.yoffset);
> }
This should be:
cursor->setPos(cursor, fbcursor->image.dx - info->var.xoffset,
fbcursor->image.dy - info->var.yoffset);
[tab][tab][tab][space][space][space][space][space][space][space]fbcursor->
Etc.
regards,
dan carpenter
prev parent reply other threads:[~2015-03-23 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 23:08 [PATCH 01/13] staging: sm750: Reintend Michel von Czettritz
2015-03-23 11:17 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323111727.GC10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).