From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 08/13] staging: sm750: comment formating
Date: Mon, 23 Mar 2015 11:22:05 +0000 [thread overview]
Message-ID: <20150323112205.GE10964@mwanda> (raw)
In-Reply-To: <20150322231340.GA17233@x230-arch.club.entropia.de>
On Mon, Mar 23, 2015 at 12:13:41AM +0100, Michel von Czettritz wrote:
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 54857ba..ab58987 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -74,19 +74,19 @@ static inline void myspin_unlock(spinlock_t *sl)
> spin_unlock(sl);
> }
> static const struct fb_videomode lynx750_ext[] = {
> - /* 1024x600-60 VESA [1.71:1] */
> + /* 1024x600-60 VESA [1.71:1]*/
Leave a space before the "*/"
> @@ -610,7 +610,7 @@ static int lynxfb_ops_setcolreg(unsigned regno, unsigned red,
> var = &info->var;
> ret = 0;
>
> - //pr_debug("regno=%d,red=%d,green=%d,blue=%d\n",regno,red,green,blue);
> + /*pr_debug("regno=%d,red=%d,green=%d,blue=%d\n",regno,red,green,blue);*/
Just delete these. Also, missing spaces next to /* and */.
regards,
dan carpenter
prev parent reply other threads:[~2015-03-23 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 23:13 [PATCH 08/13] staging: sm750: comment formating Michel von Czettritz
2015-03-23 11:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323112205.GE10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).