* [PATCH 10/13] staging: sm750: blank line after declaration
@ 2015-03-22 23:14 Michel von Czettritz
2015-03-23 11:26 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Michel von Czettritz @ 2015-03-22 23:14 UTC (permalink / raw)
To: linux-fbdev
This patch fixes "WARNING: Missing a blank line after declaration"
checkpatch.pl warnings.
Signed-off-by: Michel von Czettritz <michel.von.czettritz@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 90dc801..870bf6f 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -61,6 +61,7 @@ static char *g_option = NULL;
static inline void myspin_lock(spinlock_t *sl)
{
struct lynx_share *share;
+
share = container_of(sl, struct lynx_share, slock);
if (share->dual)
spin_lock(sl);
@@ -69,6 +70,7 @@ static inline void myspin_lock(spinlock_t *sl)
static inline void myspin_unlock(spinlock_t *sl)
{
struct lynx_share *share;
+
share = container_of(sl, struct lynx_share, slock);
if (share->dual)
spin_unlock(sl);
@@ -172,6 +174,7 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor)
if (fbcursor->set & FB_CUR_SETCMAP) {
/* get the 16bit color of kernel means */
u16 fg, bg;
+
fg = ((info->cmap.red[fbcursor->image.fg_color] & 0xf800))|
((info->cmap.green[fbcursor->image.fg_color] & 0xfc00) >> 5)|
((info->cmap.blue[fbcursor->image.fg_color] & 0xf800) >> 11);
@@ -650,6 +653,7 @@ static int lynxfb_ops_setcolreg(unsigned regno, unsigned red,
if (info->fix.visual = FB_VISUAL_TRUECOLOR && regno < 256) {
u32 val;
+
if (var->bits_per_pixel = 16 ||
var->bits_per_pixel = 32 ||
var->bits_per_pixel = 24) {
@@ -1187,6 +1191,7 @@ ALLOC_FB:
} else {
struct lynxfb_par *par;
int errno;
+
pr_info("framebuffer #%d alloc okay\n", fbidx);
share->fbinfo[fbidx] = info[fbidx];
par = info[fbidx]->par;
--
2.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 10/13] staging: sm750: blank line after declaration
2015-03-22 23:14 [PATCH 10/13] staging: sm750: blank line after declaration Michel von Czettritz
@ 2015-03-23 11:26 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-03-23 11:26 UTC (permalink / raw)
To: linux-fbdev
On Mon, Mar 23, 2015 at 12:14:17AM +0100, Michel von Czettritz wrote:
> This patch fixes "WARNING: Missing a blank line after declaration"
> checkpatch.pl warnings.
>
> Signed-off-by: Michel von Czettritz <michel.von.czettritz@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 90dc801..870bf6f 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -61,6 +61,7 @@ static char *g_option = NULL;
> static inline void myspin_lock(spinlock_t *sl)
> {
> struct lynx_share *share;
> +
These introduces new checkpatch warnings. Use checkpatch.pl on your own
patches.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-23 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-22 23:14 [PATCH 10/13] staging: sm750: blank line after declaration Michel von Czettritz
2015-03-23 11:26 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).