From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sm750fb: Fix C99 comment and if-else braces
Date: Mon, 23 Mar 2015 12:48:53 +0000 [thread overview]
Message-ID: <20150323124800.GA8151@sudip-PC> (raw)
In-Reply-To: <20150320142455.GA17954@amitoj-Inspiron-3542>
On Fri, Mar 20, 2015 at 07:54:56PM +0530, Amitoj Kaur Chawla wrote:
> The edits have been made to fix C99 Comment and properly indent
> the if-else statements with the braces.
i think you are doing multiple types of changes in one patch.
better to send it in a series of two, one for the C99 and the other
for the if-else. and there are few more places in that file where C99
is used, any reason why you have chosen only one?
scripts/checkpatch.pl --strict -f drivers/staging/sm750fb/ddk750_chip.c | grep C99 | wc -l
6
and, your patch is not applying, please refresh your patch
against staging-testing.
regards
sudip
>
prev parent reply other threads:[~2015-03-23 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 14:36 [PATCH] sm750fb: Fix C99 comment and if-else braces Amitoj Kaur Chawla
2015-03-23 12:48 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323124800.GA8151@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=amitoj1606@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).