From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 06/12] staging: sm750: no braces for single stmt if blocks
Date: Fri, 27 Mar 2015 06:00:07 +0000 [thread overview]
Message-ID: <20150327060007.GZ10964@mwanda> (raw)
In-Reply-To: <9b7d1ab21e735024fec2d2586fb1e0550eaa6369.1427406762.git.michel.von.czettritz@gmail.com>
On Thu, Mar 26, 2015 at 11:25:50PM +0100, Michel von Czettritz wrote:
> @@ -487,8 +484,8 @@ static int lynxfb_resume(struct pci_dev *pdev)
> par = info->par;
> crtc = &par->crtc;
> cursor = &crtc->cursor;
> - memset_io(cursor->vstart, 0x0, cursor->size);
> - memset_io(crtc->vScreen, 0x0, crtc->vidmem_size);
> + memset(cursor->vstart, 0x0, cursor->size);
> + memset(crtc->vScreen, 0x0, crtc->vidmem_size);
> lynxfb_ops_set_par(info);
> fb_set_suspend(info, 0);
> }
This is a bug.
regards,
dan carpenter
prev parent reply other threads:[~2015-03-27 6:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 22:25 [PATCH v2 06/12] staging: sm750: no braces for single stmt if blocks Michel von Czettritz
2015-03-27 6:00 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327060007.GZ10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).