From: Greg KH <gregkh@linuxfoundation.org>
To: Charles Rose <charles.rose.linux@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: cleanup white space and indent
Date: Fri, 24 Apr 2015 08:22:30 +0000 [thread overview]
Message-ID: <20150424082230.GA7692@kroah.com> (raw)
In-Reply-To: <1429823048-9094-1-git-send-email-charles.rose.linux@gmail.com>
On Thu, Apr 23, 2015 at 05:04:08PM -0400, Charles Rose wrote:
> This patch fixes "space prohibited" errors reported by checkpatch.pl
> and related indentation. The module builds without error.
That's two different things, can you break this up into one "logical"
patch per thing you are changing here?
thanks,
greg k-h
prev parent reply other threads:[~2015-04-24 8:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 21:04 [PATCH] staging: sm750fb: cleanup white space and indent Charles Rose
2015-04-24 7:14 ` Sudip Mukherjee
2015-04-24 8:22 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424082230.GA7692@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=charles.rose.linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).