From: Lee Jones <lee.jones@linaro.org>
To: Arun Bharadwaj <arun@gumstix.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jingoo Han <jg1.han@samsung.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Ash Charles <ashcharles@gmail.com>
Subject: Re: [PATCH] gpio-backlight: Discover driver during boot time
Date: Wed, 29 Apr 2015 12:33:03 +0000 [thread overview]
Message-ID: <20150429123303.GK9169@x1> (raw)
In-Reply-To: <20150429123223.GJ9169@x1>
> Jingoo?
Never mind.
Applied, thanks.
> > The gpio-backlight driver seems to be missing the
> > MODULE_DEVICE_TABLE line which is preventing it from
> > being modprobed during boot time even if the
> > gpio-backlight device exists.
> >
> > This seems to be a bug and this patch attempts to
> > fix that.
> >
> > Signed-off-by: Arun Bharadwaj <arun@gumstix.com>
> > Signed-off-by: Ash Charles <ashcharles@gmail.com>
> > ---
> > drivers/video/backlight/gpio_backlight.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> > index 439feb2..5fbbc2e 100644
> > --- a/drivers/video/backlight/gpio_backlight.c
> > +++ b/drivers/video/backlight/gpio_backlight.c
> > @@ -146,6 +146,8 @@ static struct of_device_id gpio_backlight_of_match[] = {
> > { .compatible = "gpio-backlight" },
> > { /* sentinel */ }
> > };
> > +
> > +MODULE_DEVICE_TABLE(of, gpio_backlight_of_match);
> > #endif
> >
> > static struct platform_driver gpio_backlight_driver = {
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-04-29 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 0:21 [PATCH] gpio-backlight: Discover driver during boot time Arun Bharadwaj
2015-04-29 12:32 ` Lee Jones
2015-04-29 12:33 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429123303.GK9169@x1 \
--to=lee.jones@linaro.org \
--cc=arun@gumstix.com \
--cc=ashcharles@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).