* [PATCH] staging: sm750fb: remove duplicate from fb_videomode
@ 2015-05-26 15:22 Michel von Czettritz
2015-05-27 6:41 ` Sudip Mukherjee
2015-05-27 8:29 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Michel von Czettritz @ 2015-05-26 15:22 UTC (permalink / raw)
To: linux-fbdev
As suggested by Sudip this patch removes the redundant 1360x768@60
option from the fb_videomode struct array.
The removed option and the option one it differ in a typo and a flag.
Signed-off-by: Michel von Czettritz <michel.von.czettritz@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 69b18f3..d90b463 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -88,9 +88,6 @@ static const struct fb_videomode lynx750_ext[] = {
FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
FB_VMODE_NONINTERLACED},
- {NULL, 60, 1360, 768, 11804, 208, 64, 23, 1, 144, 3,
- FB_SYNC_HOR_HIGH_ACT|FB_VMODE_NONINTERLACED},
-
/* 1360 x 768 [1.77083:1] */
{NULL, 60, 1360, 768, 11804, 208, 64, 23, 1, 144, 3,
FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
--
2.3.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: remove duplicate from fb_videomode
2015-05-26 15:22 [PATCH] staging: sm750fb: remove duplicate from fb_videomode Michel von Czettritz
@ 2015-05-27 6:41 ` Sudip Mukherjee
2015-05-27 8:29 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-05-27 6:41 UTC (permalink / raw)
To: linux-fbdev
On Tue, May 26, 2015 at 05:22:39PM +0200, Michel von Czettritz wrote:
> As suggested by Sudip this patch removes the redundant 1360x768@60
> option from the fb_videomode struct array.
this can be in the comments but should not be there in the commit message.
regards
sudip
> The removed option and the option one it differ in a typo and a flag.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: remove duplicate from fb_videomode
2015-05-26 15:22 [PATCH] staging: sm750fb: remove duplicate from fb_videomode Michel von Czettritz
2015-05-27 6:41 ` Sudip Mukherjee
@ 2015-05-27 8:29 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-05-27 8:29 UTC (permalink / raw)
To: linux-fbdev
On Wed, May 27, 2015 at 11:59:21AM +0530, Sudip Mukherjee wrote:
> On Tue, May 26, 2015 at 05:22:39PM +0200, Michel von Czettritz wrote:
> > As suggested by Sudip this patch removes the redundant 1360x768@60
> > option from the fb_videomode struct array.
> this can be in the comments but should not be there in the commit message.
>
No no. It's fine.
I sometimes give credit in the permanent log or in the meta comments
depending on how much credit/blame is deserved. :P
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-27 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-26 15:22 [PATCH] staging: sm750fb: remove duplicate from fb_videomode Michel von Czettritz
2015-05-27 6:41 ` Sudip Mukherjee
2015-05-27 8:29 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).