From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 27 May 2015 08:29:48 +0000 Subject: Re: [PATCH] staging: sm750fb: remove duplicate from fb_videomode Message-Id: <20150527082948.GP11588@mwanda> List-Id: References: <20150526152239.GA21887@x230-arch.club.entropia.de> In-Reply-To: <20150526152239.GA21887@x230-arch.club.entropia.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-fbdev@vger.kernel.org On Wed, May 27, 2015 at 11:59:21AM +0530, Sudip Mukherjee wrote: > On Tue, May 26, 2015 at 05:22:39PM +0200, Michel von Czettritz wrote: > > As suggested by Sudip this patch removes the redundant 1360x768@60 > > option from the fb_videomode struct array. > this can be in the comments but should not be there in the commit message. > No no. It's fine. I sometimes give credit in the permanent log or in the meta comments depending on how much credit/blame is deserved. :P regards, dan carpenter