From: Ingo Molnar <mingo@kernel.org>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Juergen Gross <jgross@suse.com>, Jingoo Han <jg1.han@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Masanari Iida <standby24x7@gmail.com>,
Suresh Siddha <sbsiddha@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Andy Lutomirski <luto@amacapital.net>,
Dave Airlie <airlied@redhat.com>,
Antonino Daplas <adaplas@gmail.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v4 3/17] video: fbdev: gbefb: use arch_phys_wc_add() and devm_ioremap_wc()
Date: Fri, 29 May 2015 06:41:44 +0000 [thread overview]
Message-ID: <20150529064144.GA22749@gmail.com> (raw)
In-Reply-To: <1432859434-17821-3-git-send-email-mcgrof@do-not-panic.com>
* Luis R. Rodriguez <mcgrof@do-not-panic.com> wrote:
> + gbe_mem = devm_ioremap_wc(&p_dev->dev, gbe_mem_phys,
> + gbe_mem_size);
> + gbe_mem = dma_alloc_writecombine(NULL, gbe_mem_size,
> + &gbe_dma_addr, GFP_KERNEL);
> + par->wc_cookie = arch_phys_wc_add(gbe_mem_phys, gbe_mem_size);
> + arch_phys_wc_del(par->wc_cookie);
> + arch_phys_wc_del(par->wc_cookie);
Could we _please_ rename dma_*_writecombine() to dma_*_wc(), so that the naming is
coherent across the various APIs?
Thanks,
Ingo
next prev parent reply other threads:[~2015-05-29 6:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 0:30 [PATCH v4 0/17] framebuffer: simple conversions to arch_phys_wc_add() Luis R. Rodriguez
2015-05-29 0:30 ` [PATCH v4 2/17] video: fbdev: gbefb: add missing mtrr_del() calls Luis R. Rodriguez
2015-05-29 0:30 ` [PATCH v4 3/17] video: fbdev: gbefb: use arch_phys_wc_add() and devm_ioremap_wc() Luis R. Rodriguez
2015-05-29 6:41 ` Ingo Molnar [this message]
2015-05-30 0:32 ` Luis R. Rodriguez
2015-06-01 8:53 ` Ingo Molnar
2015-06-01 15:57 ` Luis R. Rodriguez
2015-05-29 5:48 ` [PATCH v4 0/17] framebuffer: simple conversions to arch_phys_wc_add() Tomi Valkeinen
2015-05-29 21:04 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529064144.GA22749@gmail.com \
--to=mingo@kernel.org \
--cc=adaplas@gmail.com \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=jg1.han@samsung.com \
--cc=jgross@suse.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mingo@elte.hu \
--cc=plagnioj@jcrosoft.com \
--cc=sbsiddha@gmail.com \
--cc=standby24x7@gmail.com \
--cc=tglx@linutronix.de \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).