From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Date: Mon, 01 Jun 2015 08:53:32 +0000 Subject: Re: [PATCH v4 3/17] video: fbdev: gbefb: use arch_phys_wc_add() and devm_ioremap_wc() Message-Id: <20150601085332.GA14549@gmail.com> List-Id: References: <1432859434-17821-1-git-send-email-mcgrof@do-not-panic.com> <1432859434-17821-3-git-send-email-mcgrof@do-not-panic.com> <20150529064144.GA22749@gmail.com> <20150530003256.GG23057@wotan.suse.de> In-Reply-To: <20150530003256.GG23057@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Luis R. Rodriguez" Cc: tomi.valkeinen@ti.com, Dave Airlie , "Luis R. Rodriguez" , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Gleixner , Juergen Gross , Jingoo Han , Daniel Vetter , Masanari Iida , Suresh Siddha , Ingo Molnar , Andy Lutomirski , Antonino Daplas , Jean-Christophe Plagniol-Villard * Luis R. Rodriguez wrote: > On Fri, May 29, 2015 at 08:41:44AM +0200, Ingo Molnar wrote: > > > > * Luis R. Rodriguez wrote: > > > > > + gbe_mem = devm_ioremap_wc(&p_dev->dev, gbe_mem_phys, > > > + gbe_mem_size); > > > > > + gbe_mem = dma_alloc_writecombine(NULL, gbe_mem_size, > > > + &gbe_dma_addr, GFP_KERNEL); > > > > > + par->wc_cookie = arch_phys_wc_add(gbe_mem_phys, gbe_mem_size); > > > > > + arch_phys_wc_del(par->wc_cookie); > > > > > + arch_phys_wc_del(par->wc_cookie); > > > > Could we _please_ rename dma_*_writecombine() to dma_*_wc(), so that the naming is > > coherent across the various APIs? > > Sure, OK done. Will send once this series is merged and visible on linux-next. > But who's tree should this go through? Since it depends on this series which > goes through Tomi's tree should it go through there? So we could do the rename near the end of the merge window, when all the patches have drained from maintainer trees into Linus's tree. Mind keeping it in your tree until then? Thanks, Ingo