From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Isaac Assegai <isaac.a.travers@gmail.com>
Cc: gregkh@linuxfoundation.org, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/12] Staging: sm750fb: sm750.h: Insert spaces after commas.
Date: Tue, 02 Jun 2015 06:37:50 +0000 [thread overview]
Message-ID: <20150602062550.GD6382@sudip-PC> (raw)
In-Reply-To: <1433134873-9869-4-git-send-email-isaac.a.travers@gmail.com>
On Sun, May 31, 2015 at 10:01:04PM -0700, Isaac Assegai wrote:
> Insert Spaces after commas to rectify the
> following checkpatch errors in sm750.h:
> ERROR: space required after that ','
>
> Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.h | 35 ++++++++++++++++++-----------------
> 1 file changed, 18 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index 5528912..5f86077 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -12,7 +12,7 @@
> #define MB(x) ((x)<<20)
> #define MHZ(x) ((x) * 1000000)
> /* align should be 2,4,8,16 */
> -#define PADDING(align,data) (((data)+(align)-1)&(~((align) -1)))
> +#define PADDING(align, data) (((data)+(align)-1)&(~((align) -1)))
> extern int smi_indent;
>
>
> @@ -27,15 +27,16 @@ struct lynx_accel{
>
>
> - int (*de_imageblit)(struct lynx_accel *,const char *,u32,u32,u32,
> - u32,u32,u32,u32,u32,u32,u32,u32,u32);
> + int (*de_imageblit)(struct lynx_accel *, const char *, u32, u32, u32, u32,
^^^^^
oops, trailing whitespace errors :(
> + u32, u32, u32, u32,
^^^^^
here also
please test your patch with checkpatch before sending
regards
sudip
next prev parent reply other threads:[~2015-06-02 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1433134873-9869-1-git-send-email-isaac.a.travers@gmail.com>
[not found] ` <1433134873-9869-3-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:27 ` [PATCH 02/12] Staging: sm750fb: sm750_help.h: Insert spaces after commas Sudip Mukherjee
[not found] ` <1433134873-9869-4-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:37 ` Sudip Mukherjee [this message]
[not found] ` <1433134873-9869-13-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:48 ` [PATCH 12/12] Staging: sm750fb: Insert spaces after commas in three files Sudip Mukherjee
2015-06-02 7:55 ` Isaac Assegai
2015-06-02 8:37 ` Sudip Mukherjee
2015-06-02 8:30 ` Isaac Assegai
[not found] ` <1433134873-9869-11-git-send-email-isaac.a.travers@gmail.com>
2015-06-02 6:53 ` [PATCH 10/12] Staging: sm750fb: Insert spaces after commas in two files Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602062550.GD6382@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=isaac.a.travers@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).