* [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings @ 2015-06-14 17:17 Dighe, Niranjan (N.) 2015-06-14 17:43 ` [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings Dighe, Niranjan (N.) 2015-06-15 5:39 ` [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings Sudip Mukherjee 0 siblings, 2 replies; 6+ messages in thread From: Dighe, Niranjan (N.) @ 2015-06-14 17:17 UTC (permalink / raw) To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Niranjan Dighe <ndighe@visteon.com> This patch removes spaces at the start of the line and replaces it by tabs Signed-off-by: Niranjan Dighe <ndighe@visteon.com> diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h index 50bcec2..cbd87c1 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.h +++ b/drivers/staging/sm750fb/ddk750_dvi.h @@ -4,16 +4,18 @@ /* dvi chip stuffs structros */ typedef long (*PFN_DVICTRL_INIT)( - unsigned char edgeSelect, - unsigned char busSelect, - unsigned char dualEdgeClkSelect, - unsigned char hsyncEnable, - unsigned char vsyncEnable, - unsigned char deskewEnable, - unsigned char deskewSetting, - unsigned char continuousSyncEnable, - unsigned char pllFilterEnable, - unsigned char pllFilterValue); + unsigned char edgeSelect, + unsigned char busSelect, + unsigned char dualEdgeClkSelect, + unsigned char hsyncEnable, + unsigned char vsyncEnable, + unsigned char deskewEnable, + unsigned char deskewSetting, + unsigned char continuousSyncEnable, + unsigned char pllFilterEnable, + unsigned char pllFilterValue +); + typedef void (*PFN_DVICTRL_RESETCHIP)(void); typedef char* (*PFN_DVICTRL_GETCHIPSTRING)(void); typedef unsigned short (*PFN_DVICTRL_GETVENDORID)(void); @@ -24,44 +26,39 @@ typedef unsigned char (*PFN_DVICTRL_ISCONNECTED)(void); typedef unsigned char (*PFN_DVICTRL_CHECKINTERRUPT)(void); typedef void (*PFN_DVICTRL_CLEARINTERRUPT)(void); - - /* Structure to hold all the function pointer to the DVI Controller. */ typedef struct _dvi_ctrl_device_t { - PFN_DVICTRL_INIT pfnInit; - PFN_DVICTRL_RESETCHIP pfnResetChip; - PFN_DVICTRL_GETCHIPSTRING pfnGetChipString; - PFN_DVICTRL_GETVENDORID pfnGetVendorId; - PFN_DVICTRL_GETDEVICEID pfnGetDeviceId; - PFN_DVICTRL_SETPOWER pfnSetPower; - PFN_DVICTRL_HOTPLUGDETECTION pfnEnableHotPlugDetection; - PFN_DVICTRL_ISCONNECTED pfnIsConnected; - PFN_DVICTRL_CHECKINTERRUPT pfnCheckInterrupt; - PFN_DVICTRL_CLEARINTERRUPT pfnClearInterrupt; + PFN_DVICTRL_INIT pfnInit; + PFN_DVICTRL_RESETCHIP pfnResetChip; + PFN_DVICTRL_GETCHIPSTRING pfnGetChipString; + PFN_DVICTRL_GETVENDORID pfnGetVendorId; + PFN_DVICTRL_GETDEVICEID pfnGetDeviceId; + PFN_DVICTRL_SETPOWER pfnSetPower; + PFN_DVICTRL_HOTPLUGDETECTION pfnEnableHotPlugDetection; + PFN_DVICTRL_ISCONNECTED pfnIsConnected; + PFN_DVICTRL_CHECKINTERRUPT pfnCheckInterrupt; + PFN_DVICTRL_CLEARINTERRUPT pfnClearInterrupt; } dvi_ctrl_device_t; -#define DVI_CTRL_SII164 - +#define DVI_CTRL_SII164 /* dvi functions prototype */ int dviInit( - unsigned char edgeSelect, - unsigned char busSelect, - unsigned char dualEdgeClkSelect, - unsigned char hsyncEnable, - unsigned char vsyncEnable, - unsigned char deskewEnable, - unsigned char deskewSetting, - unsigned char continuousSyncEnable, - unsigned char pllFilterEnable, - unsigned char pllFilterValue + unsigned char edgeSelect, + unsigned char busSelect, + unsigned char dualEdgeClkSelect, + unsigned char hsyncEnable, + unsigned char vsyncEnable, + unsigned char deskewEnable, + unsigned char deskewSetting, + unsigned char continuousSyncEnable, + unsigned char pllFilterEnable, + unsigned char pllFilterValue ); unsigned short dviGetVendorID(void); unsigned short dviGetDeviceID(void); - - #endif -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings 2015-06-14 17:17 [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings Dighe, Niranjan (N.) @ 2015-06-14 17:43 ` Dighe, Niranjan (N.) 2015-06-14 18:45 ` Markus Böhme 2015-06-15 5:39 ` [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings Sudip Mukherjee 1 sibling, 1 reply; 6+ messages in thread From: Dighe, Niranjan (N.) @ 2015-06-14 17:43 UTC (permalink / raw) To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Niranjan Dighe <ndighe@visteon.com> This patch fixes indentation issues by replacing spaces by tabs at the start of line Signed-off-by: Niranjan Dighe <ndighe@visteon.com> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c index b2bf7e6..c73b74a 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.c +++ b/drivers/staging/sm750fb/ddk750_dvi.c @@ -1,4 +1,4 @@ -#define USE_DVICHIP +#define USE_DVICHIP #ifdef USE_DVICHIP #include "ddk750_help.h" #include "ddk750_reg.h" @@ -12,44 +12,43 @@ static dvi_ctrl_device_t g_dcftSupportedDviController[] { #ifdef DVI_CTRL_SII164 - { - .pfnInit = sii164InitChip, - .pfnGetVendorId = sii164GetVendorID, - .pfnGetDeviceId = sii164GetDeviceID, + { + .pfnInit = sii164InitChip, + .pfnGetVendorId = sii164GetVendorID, + .pfnGetDeviceId = sii164GetDeviceID, #ifdef SII164_FULL_FUNCTIONS - .pfnResetChip = sii164ResetChip, - .pfnGetChipString = sii164GetChipString, - .pfnSetPower = sii164SetPower, - .pfnEnableHotPlugDetection = sii164EnableHotPlugDetection, - .pfnIsConnected = sii164IsConnected, - .pfnCheckInterrupt = sii164CheckInterrupt, - .pfnClearInterrupt = sii164ClearInterrupt, + .pfnResetChip = sii164ResetChip, + .pfnGetChipString = sii164GetChipString, + .pfnSetPower = sii164SetPower, + .pfnEnableHotPlugDetection = sii164EnableHotPlugDetection, + .pfnIsConnected = sii164IsConnected, + .pfnCheckInterrupt = sii164CheckInterrupt, + .pfnClearInterrupt = sii164ClearInterrupt, #endif - }, + }, #endif }; - int dviInit( - unsigned char edgeSelect, - unsigned char busSelect, - unsigned char dualEdgeClkSelect, - unsigned char hsyncEnable, - unsigned char vsyncEnable, - unsigned char deskewEnable, - unsigned char deskewSetting, - unsigned char continuousSyncEnable, - unsigned char pllFilterEnable, - unsigned char pllFilterValue - ) + unsigned char edgeSelect, + unsigned char busSelect, + unsigned char dualEdgeClkSelect, + unsigned char hsyncEnable, + unsigned char vsyncEnable, + unsigned char deskewEnable, + unsigned char deskewSetting, + unsigned char continuousSyncEnable, + unsigned char pllFilterEnable, + unsigned char pllFilterValue +) { dvi_ctrl_device_t *pCurrentDviCtrl; pCurrentDviCtrl = g_dcftSupportedDviController; - if(pCurrentDviCtrl->pfnInit != NULL) + if (pCurrentDviCtrl->pfnInit != NULL) { return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable, - vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable, - pllFilterEnable, pllFilterValue); + vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable, + pllFilterEnable, pllFilterValue); } return -1; /* error */ } @@ -64,13 +63,13 @@ int dviInit( */ unsigned short dviGetVendorID(void) { - dvi_ctrl_device_t *pCurrentDviCtrl; + dvi_ctrl_device_t *pCurrentDviCtrl; - pCurrentDviCtrl = g_dcftSupportedDviController; - if (pCurrentDviCtrl != (dvi_ctrl_device_t *)0) - return pCurrentDviCtrl->pfnGetVendorId(); + pCurrentDviCtrl = g_dcftSupportedDviController; + if (pCurrentDviCtrl != (dvi_ctrl_device_t *)0) + return pCurrentDviCtrl->pfnGetVendorId(); - return 0x0000; + return 0x0000; } @@ -83,15 +82,14 @@ unsigned short dviGetVendorID(void) */ unsigned short dviGetDeviceID(void) { - dvi_ctrl_device_t *pCurrentDviCtrl; + dvi_ctrl_device_t *pCurrentDviCtrl; pCurrentDviCtrl = g_dcftSupportedDviController; - if (pCurrentDviCtrl != (dvi_ctrl_device_t *)0) - return pCurrentDviCtrl->pfnGetDeviceId(); + if (pCurrentDviCtrl != (dvi_ctrl_device_t *)0) + return pCurrentDviCtrl->pfnGetDeviceId(); - return 0x0000; + return 0x0000; } #endif - -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings 2015-06-14 17:43 ` [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings Dighe, Niranjan (N.) @ 2015-06-14 18:45 ` Markus Böhme 2015-06-15 3:34 ` Dighe, Niranjan (N.) 0 siblings, 1 reply; 6+ messages in thread From: Markus Böhme @ 2015-06-14 18:45 UTC (permalink / raw) To: Dighe, Niranjan (N.) Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org > This patch fixes indentation issues by replacing spaces by tabs at > the start of line > > Signed-off-by: Niranjan Dighe <ndighe@visteon.com> > > diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c > index b2bf7e6..c73b74a 100644 > --- a/drivers/staging/sm750fb/ddk750_dvi.c > +++ b/drivers/staging/sm750fb/ddk750_dvi.c > - if(pCurrentDviCtrl->pfnInit != NULL) > + if (pCurrentDviCtrl->pfnInit != NULL) You are fixing a different type of warning here. Please make only one kind of change per patch. Regards, Markus ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings 2015-06-14 18:45 ` Markus Böhme @ 2015-06-15 3:34 ` Dighe, Niranjan (N.) 0 siblings, 0 replies; 6+ messages in thread From: Dighe, Niranjan (N.) @ 2015-06-15 3:34 UTC (permalink / raw) To: Markus Böhme Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org On Sun, Jun 14, 2015 at 08:45:02PM +0200, Markus Böhme wrote: > >This patch fixes indentation issues by replacing spaces by tabs at > >the start of line > > > >Signed-off-by: Niranjan Dighe <ndighe@visteon.com> > > > >diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c > >index b2bf7e6..c73b74a 100644 > >--- a/drivers/staging/sm750fb/ddk750_dvi.c > >+++ b/drivers/staging/sm750fb/ddk750_dvi.c > > >- if(pCurrentDviCtrl->pfnInit != NULL) > >+ if (pCurrentDviCtrl->pfnInit != NULL) > > You are fixing a different type of warning here. Please make only one > kind of change per patch. > > Regards, > Markus > Hello Markus, Thanks for your review. I will correct and resend a new patch. Please disregard this for the moment. Thanks, Niranjan Dighe ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings 2015-06-14 17:17 [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings Dighe, Niranjan (N.) 2015-06-14 17:43 ` [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings Dighe, Niranjan (N.) @ 2015-06-15 5:39 ` Sudip Mukherjee 2015-06-15 10:23 ` Dighe, Niranjan (N.) 1 sibling, 1 reply; 6+ messages in thread From: Sudip Mukherjee @ 2015-06-15 5:39 UTC (permalink / raw) To: Dighe, Niranjan (N.) Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org On Sun, Jun 14, 2015 at 05:17:43PM +0000, Dighe, Niranjan (N.) wrote: > From: Niranjan Dighe <ndighe@visteon.com> > > This patch removes spaces at the start of the line and replaces it > by tabs You are also removing blank lines, adding blank lines, moving a ')' to next line. regards sudip ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings 2015-06-15 5:39 ` [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings Sudip Mukherjee @ 2015-06-15 10:23 ` Dighe, Niranjan (N.) 0 siblings, 0 replies; 6+ messages in thread From: Dighe, Niranjan (N.) @ 2015-06-15 10:23 UTC (permalink / raw) To: Sudip Mukherjee Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org On Mon, Jun 15, 2015 at 10:57:33AM +0530, Sudip Mukherjee wrote: > On Sun, Jun 14, 2015 at 05:17:43PM +0000, Dighe, Niranjan (N.) wrote: > > From: Niranjan Dighe <ndighe@visteon.com> > > > > This patch removes spaces at the start of the line and replaces it > > by tabs > You are also removing blank lines, adding blank lines, moving a ')' to > next line. > > regards > sudip Alright. I will modify the patch and resend. Thanks, Niranjan ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-15 10:23 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-06-14 17:17 [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings Dighe, Niranjan (N.) 2015-06-14 17:43 ` [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings Dighe, Niranjan (N.) 2015-06-14 18:45 ` Markus Böhme 2015-06-15 3:34 ` Dighe, Niranjan (N.) 2015-06-15 5:39 ` [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings Sudip Mukherjee 2015-06-15 10:23 ` Dighe, Niranjan (N.)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).