linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Dighe, Niranjan (N.)" <ndighe@visteon.com>
To: "Markus Böhme" <markus.boehme@mailbox.org>
Cc: "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
	"teddy.wang@siliconmotion.com" <teddy.wang@siliconmotion.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings
Date: Mon, 15 Jun 2015 03:34:25 +0000	[thread overview]
Message-ID: <20150615033409.GA2277@siberianhusky> (raw)
In-Reply-To: <557DCBAE.8070109@mailbox.org>

On Sun, Jun 14, 2015 at 08:45:02PM +0200, Markus Böhme wrote:
> >This patch fixes indentation issues by replacing spaces by tabs at
> >the start of line
> >
> >Signed-off-by: Niranjan Dighe <ndighe@visteon.com>
> >
> >diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> >index b2bf7e6..c73b74a 100644
> >--- a/drivers/staging/sm750fb/ddk750_dvi.c
> >+++ b/drivers/staging/sm750fb/ddk750_dvi.c
> 
> >-	if(pCurrentDviCtrl->pfnInit != NULL)
> >+	if (pCurrentDviCtrl->pfnInit != NULL)
> 
> You are fixing a different type of warning here. Please make only one
> kind of change per patch.
> 
> Regards,
> Markus
> 

Hello Markus,

Thanks for your review. I will correct and resend a new patch. Please disregard
this for the moment.

Thanks,
Niranjan Dighe

  reply	other threads:[~2015-06-15  3:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-14 17:17 [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings Dighe, Niranjan (N.)
2015-06-14 17:43 ` [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings Dighe, Niranjan (N.)
2015-06-14 18:45   ` Markus Böhme
2015-06-15  3:34     ` Dighe, Niranjan (N.) [this message]
2015-06-15  5:39 ` [PATCH] Staging: sm750fb: Fix checkpatch.pl warnings Sudip Mukherjee
2015-06-15 10:23   ` Dighe, Niranjan (N.)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150615033409.GA2277@siberianhusky \
    --to=ndighe@visteon.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.boehme@mailbox.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).