linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Isaac Assegai <isaac.a.travers@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-fbdev@vger.kernel.org, teddy.wang@siliconmotion.com,
	sudipm.mukherjee@gmail.com
Subject: Re: [PATCH 9/9] Staging: sm750fb: ddk750_swi2c.c: Shorten lines to 80 characters
Date: Fri, 19 Jun 2015 05:09:52 +0000	[thread overview]
Message-ID: <20150619050952.GA2990@kroah.com> (raw)
In-Reply-To: <1434689336-10647-10-git-send-email-isaac.a.travers@gmail.com>

On Thu, Jun 18, 2015 at 09:48:56PM -0700, Isaac Assegai wrote:
> Shorten lines to be under 80 characters in ddk750_swi2c.c
> to rectify the following checkpatch warnings:
> WARNING: line over 80 characters
> 
> Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_swi2c.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c
> index 5133bcc..1e684e2 100644
> --- a/drivers/staging/sm750fb/ddk750_swi2c.c
> +++ b/drivers/staging/sm750fb/ddk750_swi2c.c
> @@ -126,7 +126,10 @@ void swI2CSCL(unsigned char value)
>  
>  	ulGPIODirection = PEEK32(g_i2cClkGPIODataDirReg);
>  	if (value) {    /* High */
> -		/* Set direction as input. This will automatically pull the signal up. */
> +		/**

Multi-line comments don't have two ** characters, that's just for
kerneldoc format, so I can't take this patch.

thanks,

greg k-h

           reply	other threads:[~2015-06-19  5:09 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1434689336-10647-10-git-send-email-isaac.a.travers@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150619050952.GA2990@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=isaac.a.travers@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).