* Re: [PATCH 9/9] Staging: sm750fb: ddk750_swi2c.c: Shorten lines to 80 characters
[not found] ` <1434689336-10647-10-git-send-email-isaac.a.travers@gmail.com>
@ 2015-06-19 5:09 ` Greg KH
0 siblings, 0 replies; only message in thread
From: Greg KH @ 2015-06-19 5:09 UTC (permalink / raw)
To: Isaac Assegai
Cc: linux-kernel, devel, linux-fbdev, teddy.wang, sudipm.mukherjee
On Thu, Jun 18, 2015 at 09:48:56PM -0700, Isaac Assegai wrote:
> Shorten lines to be under 80 characters in ddk750_swi2c.c
> to rectify the following checkpatch warnings:
> WARNING: line over 80 characters
>
> Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_swi2c.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c
> index 5133bcc..1e684e2 100644
> --- a/drivers/staging/sm750fb/ddk750_swi2c.c
> +++ b/drivers/staging/sm750fb/ddk750_swi2c.c
> @@ -126,7 +126,10 @@ void swI2CSCL(unsigned char value)
>
> ulGPIODirection = PEEK32(g_i2cClkGPIODataDirReg);
> if (value) { /* High */
> - /* Set direction as input. This will automatically pull the signal up. */
> + /**
Multi-line comments don't have two ** characters, that's just for
kerneldoc format, so I can't take this patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-19 5:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1434689336-10647-1-git-send-email-isaac.a.travers@gmail.com>
[not found] ` <1434689336-10647-10-git-send-email-isaac.a.travers@gmail.com>
2015-06-19 5:09 ` [PATCH 9/9] Staging: sm750fb: ddk750_swi2c.c: Shorten lines to 80 characters Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).