From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Joe Perches <joe@perches.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/9] staging: sm7xxfb: fix alignment
Date: Fri, 19 Jun 2015 14:45:14 +0000 [thread overview]
Message-ID: <20150619144514.GS28762@mwanda> (raw)
In-Reply-To: <1434540288-8289-6-git-send-email-sudipm.mukherjee@gmail.com>
On Wed, Jun 17, 2015 at 04:54:44PM +0530, Sudip Mukherjee wrote:
> @@ -346,9 +346,8 @@ static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, size_t
> dst = buffer;
> for (i = c >> 2; i--;) {
> *dst = fb_readl(src++);
> - *dst > - (*dst & 0xff00ff00 >> 8) |
> - (*dst & 0x00ff00ff << 8);
> + *dst = (*dst & 0xff00ff00 >> 8) |
> + (*dst & 0x00ff00ff << 8);
This is supposed to convert __le16 to __be16?
> dst++;
> }
> if (c & 3) {
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
next prev parent reply other threads:[~2015-06-19 14:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 11:36 [PATCH v2 0/9] fix sm7xxfb Sudip Mukherjee
2015-06-17 11:36 ` [PATCH v2 1/9] staging: sm7xxfb: declare struct as const Sudip Mukherjee
2015-06-17 11:36 ` [PATCH v2 2/9] staging: sm7xxfb: remove numvgamodes Sudip Mukherjee
2015-06-17 11:36 ` [PATCH v2 3/9] staging: sm7xxfb: add newline Sudip Mukherjee
2015-06-17 11:36 ` [PATCH v2 4/9] staging: sm7xxfb: no space after cast Sudip Mukherjee
2015-06-17 11:36 ` [PATCH v2 5/9] staging: sm7xxfb: fix alignment Sudip Mukherjee
2015-06-19 14:45 ` Dan Carpenter [this message]
2015-06-17 11:36 ` [PATCH v2 6/9] staging: sm7xxfb: reduce indention Sudip Mukherjee
2015-06-17 11:36 ` [PATCH v2 7/9] staging: sm7xxfb: move mode table Sudip Mukherjee
2015-06-19 14:48 ` Dan Carpenter
2015-06-17 11:36 ` [PATCH v2 8/9] staging: sm7xxfb: fix indention Sudip Mukherjee
2015-06-19 14:50 ` Dan Carpenter
2015-06-17 11:36 ` [PATCH v2 9/9] staging: sm7xxfb: fix camelcase Sudip Mukherjee
2015-06-19 14:51 ` Dan Carpenter
2015-06-18 4:43 ` [PATCH v2 0/9] fix sm7xxfb Greg Kroah-Hartman
2015-06-18 4:45 ` Greg Kroah-Hartman
2015-06-18 8:49 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619144514.GS28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).