From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Juston Li <juston.h.li@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: sm750fb: use tabs for indentation
Date: Sat, 20 Jun 2015 07:55:35 +0000 [thread overview]
Message-ID: <20150620074335.GB15195@sudip-PC> (raw)
In-Reply-To: <1434779457-18601-1-git-send-email-juston.h.li@gmail.com>
On Fri, Jun 19, 2015 at 10:50:57PM -0700, Juston Li wrote:
> Replace spaces with tabs for indentation to fix the checkpatch.pl warning
> 'WARNING: please, no spaces at the start of a line'
>
> checkpatch doesn't catch comments indented by spaces but I fixed comments
> adjacent to warnings as well so they would remain aligned.
>
> Signed-off-by: Juston Li <juston.h.li@gmail.com>
> ---
<snip>
> diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c
> index 7826376..23d6e19 100644
> --- a/drivers/staging/sm750fb/ddk750_hwi2c.c
> +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c
> @@ -9,71 +9,69 @@
> #define HWI2C_WAIT_TIMEOUT 0xF0000
>
>
> -int hwI2CInit(
> - unsigned char busSpeedMode
> -)
> +int hwI2CInit(unsigned char busSpeedMode)
but this is what you say in commit message. Please only do one type of
change in a single patch.
regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
next prev parent reply other threads:[~2015-06-20 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 5:50 [PATCH v3] staging: sm750fb: use tabs for indentation Juston Li
2015-06-20 7:55 ` Sudip Mukherjee [this message]
2015-06-20 8:07 ` Juston Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150620074335.GB15195@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=juston.h.li@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox