From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: remove unused variables
Date: Tue, 23 Jun 2015 08:46:13 +0000 [thread overview]
Message-ID: <20150623084613.GK28762@mwanda> (raw)
In-Reply-To: <20150622072017.GA32220@IND12F0122>
On Mon, Jun 22, 2015 at 07:26:25AM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> @@ -122,7 +121,7 @@ void setChipClock(unsigned int frequency)
> * Sometime, the chip cannot set up the exact clock required by User.
> * Return value from calcPllValue() gives the actual possible clock.
> */
> - ulActualMxClk = calcPllValue(frequency, &pll);
> + calcPllValue(frequency, &pll);
Should we get rid of calcPllValue() as well? I guess I would prefer to
leave the warnings until someone has the answer to this.
Warnings are good because they show where the bugs are. It's not always
the right thing to silence them.
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-23 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 7:26 [PATCH] staging: sm750fb: remove unused variables Gujulan Elango, Hari Prasath (H.)
2015-06-23 8:46 ` Dan Carpenter [this message]
2015-06-23 10:12 ` Sudip Mukherjee
2015-06-23 13:05 ` Gujulan Elango, Hari Prasath (H.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623084613.GK28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).