From: Dan Carpenter <dan.carpenter@oracle.com>
To: Juston Li <juston.h.li@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
teddy.wang@siliconmotion.com,
Greg KH <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement
Date: Thu, 25 Jun 2015 20:31:15 +0000 [thread overview]
Message-ID: <20150625203115.GN30834@mwanda> (raw)
In-Reply-To: <CAFow2F_zK42gJ0UoV+GwqLrfsxB2Nqi8kaB7OB+=-APftp=FfQ@mail.gmail.com>
On Thu, Jun 25, 2015 at 08:49:30AM -0700, Juston Li wrote:
> I placed it above the else to make it consistent with the if statement with
> similar comment that the else corresponds to:
>
> /* Set the primary display control */
> - if (!ctrl)+ if (!ctrl) {
Once you add the else statement, then that kind of doesn't make sense.
Sudip is right. It should be:
} else {
/* commentary about else side */
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-25 20:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 16:20 [PATCH v3 00/19] staging: sm750fb: checkpatch.pl fixes Juston Li
2015-06-24 16:25 ` [PATCH v3 01/19] staging: sm750fb: use tabs for indentation Juston Li
2015-06-24 16:25 ` [PATCH v3 02/19] staging: sm750fb: remove spacing after open parenthesis Juston Li
2015-06-24 16:25 ` [PATCH v3 03/19] staging: sm750fb: remove space before close parenthesis Juston Li
2015-06-24 16:25 ` [PATCH v3 04/19] staging: sm750fb: add space before open parenthesis Juston Li
2015-06-24 16:25 ` [PATCH v3 05/19] staging: sm750fb: remove space between function name and parenthesis Juston Li
2015-06-24 16:25 ` [PATCH v3 06/19] staging: sm750fb: add space before open brace Juston Li
2015-06-24 16:25 ` [PATCH v3 07/19] staging: sm750fb: add space after close brace Juston Li
2015-06-24 16:25 ` [PATCH v3 08/19] staging: sm750fb: add space after enum definition Juston Li
2015-06-24 16:25 ` [PATCH v3 09/19] staging: sm750fb: add space after struct definition Juston Li
2015-06-24 16:25 ` [PATCH v3 10/19] staging: sm750fb: add space after return type Juston Li
2015-06-24 16:25 ` [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators Juston Li
2015-06-25 11:56 ` Sudip Mukherjee
2015-06-25 16:26 ` Juston Li
2015-06-26 4:17 ` Sudip Mukherjee
2015-06-26 4:14 ` Juston Li
2015-06-26 5:53 ` Juston Li
2015-06-30 7:47 ` Sudip Mukherjee
2015-06-24 16:25 ` [PATCH v3 12/19] staging: sm750fb: add spaces " Juston Li
2015-06-24 16:25 ` [PATCH v3 13/19] staging: sm750fb: add space after semicolon Juston Li
2015-06-24 16:25 ` [PATCH v3 14/19] staging: sm750fb: remove trailing whitespace Juston Li
2015-06-24 16:25 ` [PATCH v3 15/19] staging: sm750fb: remove unnecessary whitespace Juston Li
2015-06-24 16:25 ` [PATCH v3 16/19] staging: sm750fb: fix brace placement Juston Li
2015-06-25 12:29 ` Sudip Mukherjee
2015-06-25 15:49 ` Juston Li
2015-06-25 20:31 ` Dan Carpenter [this message]
2015-06-25 21:27 ` Juston Li
2015-06-26 4:12 ` Sudip Mukherjee
2015-06-24 16:25 ` [PATCH v3 17/19] staging: sm750fb: move while statement to follow do close brace Juston Li
2015-06-24 16:25 ` [PATCH v3 18/19] staging: sm750fb: remove unnecessary braces Juston Li
2015-06-24 16:25 ` [PATCH v3 19/19] staging: sm750fb: add missing blank line after declarations Juston Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625203115.GN30834@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=juston.h.li@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).