From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 25 Jun 2015 20:31:15 +0000 Subject: Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement Message-Id: <20150625203115.GN30834@mwanda> List-Id: References: <1435163120-3253-16-git-send-email-juston.h.li@gmail.com> <20150625121729.GD13366@sudip-PC> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Juston Li Cc: Sudip Mukherjee , teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org On Thu, Jun 25, 2015 at 08:49:30AM -0700, Juston Li wrote: > I placed it above the else to make it consistent with the if statement with > similar comment that the else corresponds to: > > /* Set the primary display control */ > - if (!ctrl)+ if (!ctrl) { Once you add the else statement, then that kind of doesn't make sense. Sudip is right. It should be: } else { /* commentary about else side */ regards, dan carpenter