From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Juston Li <juston.h.li@gmail.com>
Cc: teddy.wang@siliconmotion.com,
Greg KH <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators
Date: Tue, 30 Jun 2015 07:47:57 +0000 [thread overview]
Message-ID: <20150630073557.GA5067@sudip-PC> (raw)
In-Reply-To: <CAFow2F9y-ux5_hoQmG-WNHCzA3aw0EB9wxJ57+zOWnYt6ds-JA@mail.gmail.com>
On Thu, Jun 25, 2015 at 10:53:33PM -0700, Juston Li wrote:
> On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > Usually I use the checkpatch which is in linux-next. That will be the
> > latest version. If you compare, last commit on checkpatch of staging
> > tree was on April 16th, where as last commit in linux-next is on
> > June 19th. And if you use this checkpatch you will see these warnings
> > also. :)
>
> Just wanted to clarify. So even with the linux-next checkpatch.pl, no
> errors/warnings show for me. Only when I run checkpatch.pl with the
> '--strict' option does it give the following checks for various operators:
> CHECK: space preferred before that '|' (ctx:VxE)
>
> Are these the warnings you are referring too? Do you want me to fix all
> of these for this patch?
Hi,
Sorry for the late reply, was a bit busy.
since your commit message was saying "spacing around operators"
and you were fixing the spacing around all types of operators so there
is no point leaving few not fixed on the same line.
But anyways, since you have already sent new series, its ok.
regards
sudip
next prev parent reply other threads:[~2015-06-30 7:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 16:20 [PATCH v3 00/19] staging: sm750fb: checkpatch.pl fixes Juston Li
2015-06-24 16:25 ` [PATCH v3 01/19] staging: sm750fb: use tabs for indentation Juston Li
2015-06-24 16:25 ` [PATCH v3 02/19] staging: sm750fb: remove spacing after open parenthesis Juston Li
2015-06-24 16:25 ` [PATCH v3 03/19] staging: sm750fb: remove space before close parenthesis Juston Li
2015-06-24 16:25 ` [PATCH v3 04/19] staging: sm750fb: add space before open parenthesis Juston Li
2015-06-24 16:25 ` [PATCH v3 05/19] staging: sm750fb: remove space between function name and parenthesis Juston Li
2015-06-24 16:25 ` [PATCH v3 06/19] staging: sm750fb: add space before open brace Juston Li
2015-06-24 16:25 ` [PATCH v3 07/19] staging: sm750fb: add space after close brace Juston Li
2015-06-24 16:25 ` [PATCH v3 08/19] staging: sm750fb: add space after enum definition Juston Li
2015-06-24 16:25 ` [PATCH v3 09/19] staging: sm750fb: add space after struct definition Juston Li
2015-06-24 16:25 ` [PATCH v3 10/19] staging: sm750fb: add space after return type Juston Li
2015-06-24 16:25 ` [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators Juston Li
2015-06-25 11:56 ` Sudip Mukherjee
2015-06-25 16:26 ` Juston Li
2015-06-26 4:17 ` Sudip Mukherjee
2015-06-26 4:14 ` Juston Li
2015-06-26 5:53 ` Juston Li
2015-06-30 7:47 ` Sudip Mukherjee [this message]
2015-06-24 16:25 ` [PATCH v3 12/19] staging: sm750fb: add spaces " Juston Li
2015-06-24 16:25 ` [PATCH v3 13/19] staging: sm750fb: add space after semicolon Juston Li
2015-06-24 16:25 ` [PATCH v3 14/19] staging: sm750fb: remove trailing whitespace Juston Li
2015-06-24 16:25 ` [PATCH v3 15/19] staging: sm750fb: remove unnecessary whitespace Juston Li
2015-06-24 16:25 ` [PATCH v3 16/19] staging: sm750fb: fix brace placement Juston Li
2015-06-25 12:29 ` Sudip Mukherjee
2015-06-25 15:49 ` Juston Li
2015-06-25 20:31 ` Dan Carpenter
2015-06-25 21:27 ` Juston Li
2015-06-26 4:12 ` Sudip Mukherjee
2015-06-24 16:25 ` [PATCH v3 17/19] staging: sm750fb: move while statement to follow do close brace Juston Li
2015-06-24 16:25 ` [PATCH v3 18/19] staging: sm750fb: remove unnecessary braces Juston Li
2015-06-24 16:25 ` [PATCH v3 19/19] staging: sm750fb: add missing blank line after declarations Juston Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630073557.GA5067@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=juston.h.li@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).