Re: [PATCH] backlight: pm8941-wled: Move PM8941 WLED driver to backlight

[Lee Jones <lee.jones@linaro.org>]

On Tue, 21 Jul 2015, Jingoo Han wrote:

> 
> On 2015. 7. 21., at AM 6:11, Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
> >> On 20.07.2015 16:15, Jingoo Han wrote:
> >>> On Thursday, July 16, 2015 5:01 PM, Jacek Anaszewski wrote:
> >>>> On 07/15/2015 10:02 PM, Bjorn Andersson wrote:
> >>>> The Qualcomm PM8941 WLED block is used for backlight and should therefor
> >>>> be in the backlight framework and not in the LED framework. This moves
> >>>> the driver and adapts to the backlight api instead.
> >>>> 
> >>>> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> >>>> ---
> >>>>   .../devicetree/bindings/leds/leds-pm8941-wled.txt  |  5 +-
> >>>>   drivers/leds/Kconfig                               |  8 ---
> >>>>   drivers/leds/Makefile                              |  1 -
> >>>>   drivers/video/backlight/Kconfig |  8 +++
> >>>>   drivers/video/backlight/Makefile                   |  1 +
> >>>>   .../backlight/pm8941-wled.c}                       | 59 ++++++++++------------
> >>>>   6 files changed, 36 insertions(+), 46 deletions(-)
> >>>>   rename drivers/{leds/leds-pm8941-wled.c => video/backlight/pm8941-wled.c} (90%)
> >>> 
> >>> Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> >> 
> >> If you are not an author of this driver or a maintainer affected by this patch,
> >> Just 'Reviewed-by' looks good.
> > 
> > I am a LED subsystem maintainer.
> 
> OK, I see.
> I didn't notice that you were added as the maintainer 2 months ago.

Please read: Sections 12 and 13 of Documentation/SubmittingPatches.

Granted, Acked-bys are used by Maintainers when reviewing changes in
subsystems they are responsible for.  However, that's not the sole use
of them.  Anyone can provide an Ack for code they have reviewed, but
are not an expert in.  Reviewed-bys have much stronger meaning and
should only be used if the supplier knows the code and the subsystem
well.  Please see SubmittingPatches for a full meaning of the
Reviewed-by tag.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog