From: Afzal Mohammed <afzal.mohd.ma@gmail.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: yalin wang <yalin.wang2010@gmail.com>,
adaplas@gmail.com, plagnioj@jcrosoft.com,
linux-fbdev@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] fbdev/riva:change to use generice function to implement reverse_order()
Date: Sat, 22 Aug 2015 07:53:34 +0000 [thread overview]
Message-ID: <20150822075310.GA2337@afzalpc> (raw)
In-Reply-To: <55D6DAE5.20304@ti.com>
Hi,
On Fri, Aug 21, 2015 at 11:01:41AM +0300, Tomi Valkeinen wrote:
> >> Possibly the patches are still good for x86 also, but that needs to be
> >> proven.
> >>
> > not exactly, because x86_64 don’t have hardware instruction to do rbit OP,
> > i compile by test :
>
> For old drivers i386 may be more relevant than x86_64.
It seems asm bit reversal is supported in Kernel on arm & arm64 only,
not sure whether any other arch even provide asm bit reversal
instruction.
> These kind of optimizations should have some real world measurements,
Not for this case, but once measured on ARM, iirc, a 32-bit asm bit
reversal as compared to doing it in C was taking 1 cycle as opposed to
~225 cycles!, of course writing optimized C could have made it fare
better, but still would reach no-way near asm bit reversal.
Regards
Afzal
next prev parent reply other threads:[~2015-08-22 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 10:12 [RFC] fbdev/riva:change to use generice function to implement reverse_order() yalin wang
2015-08-20 11:02 ` Tomi Valkeinen
2015-08-20 11:30 ` yalin wang
2015-08-21 6:41 ` Tomi Valkeinen
2015-08-21 7:46 ` yalin wang
2015-08-21 8:01 ` Tomi Valkeinen
2015-08-22 7:53 ` Afzal Mohammed [this message]
2015-08-24 8:31 ` yalin wang
2015-08-24 13:53 ` Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150822075310.GA2337@afzalpc \
--to=afzal.mohd.ma@gmail.com \
--cc=adaplas@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).