From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jingoo Han <jingoohan1@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [RESEND PATCH 2/7] backlight: tosa: Export I2C module alias information
Date: Tue, 25 Aug 2015 07:32:49 +0000 [thread overview]
Message-ID: <20150825073249.GB19409@x1> (raw)
In-Reply-To: <1440484277-32675-3-git-send-email-javier@osg.samsung.com>
On Tue, 25 Aug 2015, Javier Martinez Canillas wrote:
> The I2C core always reports the MODALIAS uevent as "i2c:<modalias>"
> regardless of the mechanism that was used to register the device
> (i.e: OF or board code) and the table that is used later to match
> the driver with the device (i.e: I2C id table or OF match table).
>
> So drivers needs to export the I2C id table and this be built into
> the module or udev won't have the necessary information to autoload
> the needed driver module when the device is added.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/video/backlight/tosa_bl.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c
> index 3ad676558c80..83742d806391 100644
> --- a/drivers/video/backlight/tosa_bl.c
> +++ b/drivers/video/backlight/tosa_bl.c
> @@ -158,6 +158,7 @@ static const struct i2c_device_id tosa_bl_id[] = {
> { "tosa-bl", 0 },
> { },
> };
> +MODULE_DEVICE_TABLE(i2c, tosa_bl_id);
>
> static struct i2c_driver tosa_bl_driver = {
> .driver = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-08-25 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 6:31 [RESEND PATCH 0/7] Export I2C and OF module aliases in missing drivers Javier Martinez Canillas
2015-08-25 6:31 ` [RESEND PATCH 2/7] backlight: tosa: Export I2C module alias information Javier Martinez Canillas
2015-08-25 7:32 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825073249.GB19409@x1 \
--to=lee.jones@linaro.org \
--cc=javier@osg.samsung.com \
--cc=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).