From: Ingo Molnar <mingo@kernel.org>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
linux-s390@vger.kernel.org, bp@suse.de, linux@roeck-us.net,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
fengguang.wu@intel.com, akpm@linux-foundation.org,
rostedt@goodmis.org, "Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH] S390: add pci_iomap_wc() and pci_iomap_wc_range()
Date: Fri, 28 Aug 2015 06:06:05 +0000 [thread overview]
Message-ID: <20150828060605.GF26741@gmail.com> (raw)
In-Reply-To: <1440632050-23648-1-git-send-email-mcgrof@do-not-panic.com>
* Luis R. Rodriguez <mcgrof@do-not-panic.com> wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>
> S390 requires its own implementation of pcio_iomap*() calls
> is because it has its "BAR spaces are not disjunctive on s390
> so we need the bar parameter of pci_iomap to find the corresponding
> device and create the mapping cookie" -- in summary, it has its own
> lookup/lock solution.
>
> It does not include asm-generic/pci_iomap.h
>
> Since it currenty maps ioremap_wc() to ioremap_nocache() and that's
> the architecture default we can easily just map the wc calls to
> the default calls as well.
>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Fengguang Wu <fengguang.wu@intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Reported-by: 0 day bot
> Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> ---
>
> This broke through some series that went into Ingo's tip tree which
> I added. As such I *think* this should go through Ingo's tip tree.
> Let me know. Up to you guys.
I fixed the changelog to explain all this.
Also, is there any other architecture that got broken by:
1b3d4200c1e0 PCI: Add pci_iomap_wc() variants
?
Thanks,
Ingo
next prev parent reply other threads:[~2015-08-28 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 23:34 [PATCH] S390: add pci_iomap_wc() and pci_iomap_wc_range() Luis R. Rodriguez
2015-08-28 6:06 ` Ingo Molnar [this message]
2015-08-28 8:22 ` Guenter Roeck
2015-08-29 0:14 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828060605.GF26741@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=fengguang.wu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=plagnioj@jcrosoft.com \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).