From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 21 Sep 2015 23:22:25 +0000 Subject: Re: [PATCH] backlight: pwm: reject legacy pwm request for device defined in dt Message-Id: <20150921232225.GF11284@x1> List-Id: References: <1434292172-22129-1-git-send-email-vladimir_zapolskiy@mentor.com> In-Reply-To: <1434292172-22129-1-git-send-email-vladimir_zapolskiy@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Vladimir Zapolskiy Cc: Jingoo Han , Thierry Reding , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org On Sun, 14 Jun 2015, Vladimir Zapolskiy wrote: > Platform PWM backlight data provided by board's device tree should be > complete enough to successfully request a pwm device using pwm_get() > API. This change fixes a bug, when an arbitrary (first found) PWM is > connected to a "pwm-backlight" compatible device, when explicit PWM > device reference is not given. >=20 > Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt > already describes "pwms" as a required property, instead of blind > selection of a potentially wrong PWM reject legacy PWM device > registration request, leave legacy API only for non-dt cases. >=20 > Based on initial implementation done by Dmitry Eremin-Solenikov. >=20 > Reported-by: Dmitry Eremin-Solenikov > Signed-off-by: Vladimir Zapolskiy > Acked-by: Thierry Reding > --- > drivers/video/backlight/pwm_bl.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) Applied, thanks. > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/p= wm_bl.c > index 57cb9ec..9991cdb 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -271,15 +271,16 @@ static int pwm_backlight_probe(struct platform_devi= ce *pdev) > } > =20 > pb->pwm =3D devm_pwm_get(&pdev->dev, NULL); > - if (IS_ERR(pb->pwm)) { > + if (IS_ERR(pb->pwm) && !pdev->dev.of_node) { > dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n"); > pb->legacy =3D true; > pb->pwm =3D pwm_request(data->pwm_id, "pwm-backlight"); > - if (IS_ERR(pb->pwm)) { > - dev_err(&pdev->dev, "unable to request legacy PWM\n"); > - ret =3D PTR_ERR(pb->pwm); > - goto err_alloc; > - } > + } > + > + if (IS_ERR(pb->pwm)) { > + dev_err(&pdev->dev, "unable to request PWM\n"); > + ret =3D PTR_ERR(pb->pwm); > + goto err_alloc; > } > =20 > dev_dbg(&pdev->dev, "got pwm for backlight\n"); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog