linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings
       [not found] <201510270209.ZSHdZKp5%fengguang.wu@intel.com>
@ 2015-10-26 18:26 ` kbuild test robot
  2015-10-26 18:33   ` Bjorn Andersson
  2015-10-27  8:39   ` Lee Jones
  0 siblings, 2 replies; 3+ messages in thread
From: kbuild test robot @ 2015-10-26 18:26 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: kbuild-all, linux-kernel, Lee Jones, Jingoo Han,
	Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev

drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 pm8941-wled.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/video/backlight/pm8941-wled.c
+++ b/drivers/video/backlight/pm8941-wled.c
@@ -401,10 +401,7 @@ static int pm8941_wled_probe(struct plat
 	bl = devm_backlight_device_register(&pdev->dev, wled->name,
 					    &pdev->dev, wled,
 					    &pm8941_wled_ops, &props);
-	if (IS_ERR(bl))
-		return PTR_ERR(bl);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(bl);
 };
 
 static const struct of_device_id pm8941_wled_match_table[] = {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings
  2015-10-26 18:26 ` [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings kbuild test robot
@ 2015-10-26 18:33   ` Bjorn Andersson
  2015-10-27  8:39   ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2015-10-26 18:33 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Bjorn Andersson, kbuild-all, linux-kernel@vger.kernel.org,
	Lee Jones, Jingoo Han, Jean-Christophe Plagniol-Villard,
	Tomi Valkeinen, linux-fbdev

On Mon, Oct 26, 2015 at 11:26 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>

Cool, I didn't know that. Thanks

Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings
  2015-10-26 18:26 ` [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings kbuild test robot
  2015-10-26 18:33   ` Bjorn Andersson
@ 2015-10-27  8:39   ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2015-10-27  8:39 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Bjorn Andersson, kbuild-all, linux-kernel, Jingoo Han,
	Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev

On Tue, 27 Oct 2015, kbuild test robot wrote:

> drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> 
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> CC: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  pm8941-wled.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Applied, thanks.

> --- a/drivers/video/backlight/pm8941-wled.c
> +++ b/drivers/video/backlight/pm8941-wled.c
> @@ -401,10 +401,7 @@ static int pm8941_wled_probe(struct plat
>  	bl = devm_backlight_device_register(&pdev->dev, wled->name,
>  					    &pdev->dev, wled,
>  					    &pm8941_wled_ops, &props);
> -	if (IS_ERR(bl))
> -		return PTR_ERR(bl);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(bl);
>  };
>  
>  static const struct of_device_id pm8941_wled_match_table[] = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-10-27  8:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <201510270209.ZSHdZKp5%fengguang.wu@intel.com>
2015-10-26 18:26 ` [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings kbuild test robot
2015-10-26 18:33   ` Bjorn Andersson
2015-10-27  8:39   ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).