From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lee Jones <lee.jones@linaro.org>
Date: Tue, 27 Oct 2015 08:39:15 +0000
Subject: Re: [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings
Message-Id: <20151027083915.GR597@x1>
List-Id: <linux-fbdev.vger.kernel.org>
References: <201510270209.ZSHdZKp5%fengguang.wu@intel.com>
 <20151026182611.GA14761@roam>
In-Reply-To: <20151026182611.GA14761@roam>
MIME-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>, kbuild-all@01.org, linux-kernel@vger.kernel.org, Jingoo Han <jingoohan1@gmail.com>, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org

On Tue, 27 Oct 2015, kbuild test robot wrote:

> drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO c=
an be used
>=20
>=20
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>=20
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>=20
> CC: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>=20
>  pm8941-wled.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Applied, thanks.

> --- a/drivers/video/backlight/pm8941-wled.c
> +++ b/drivers/video/backlight/pm8941-wled.c
> @@ -401,10 +401,7 @@ static int pm8941_wled_probe(struct plat
>  	bl =3D devm_backlight_device_register(&pdev->dev, wled->name,
>  					    &pdev->dev, wled,
>  					    &pm8941_wled_ops, &props);
> -	if (IS_ERR(bl))
> -		return PTR_ERR(bl);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(bl);
>  };
> =20
>  static const struct of_device_id pm8941_wled_match_table[] =3D {

--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog