* [PATCH 1/2] staging: sm750fb: move opening brace to previous line
@ 2015-11-08 0:43 Othmar Pasteka
2015-11-08 0:43 ` [PATCH 2/2] staging: sm750fb: add spaces around operator Othmar Pasteka
0 siblings, 1 reply; 5+ messages in thread
From: Othmar Pasteka @ 2015-11-08 0:43 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, sudip, greg
Cc: devel, linux-fbdev, linux-kernel, Othmar Pasteka
Fixes the checkpatch.pl error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Othmar Pasteka <pasteka@kabsi.at>
---
drivers/staging/sm750fb/sm750_cursor.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index 3b7ce92..cab891c 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -143,8 +143,7 @@ void hw_cursor_setData(struct lynx_cursor *cursor,
iowrite16(data, pbuffer);
/* assume pitch is 1,2,4,8,...*/
- if ((i+1) % pitch = 0)
- {
+ if ((i+1) % pitch = 0) {
/* need a return */
pstart += offset;
pbuffer = pstart;
--
2.5.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] staging: sm750fb: add spaces around operator
2015-11-08 0:43 [PATCH 1/2] staging: sm750fb: move opening brace to previous line Othmar Pasteka
@ 2015-11-08 0:43 ` Othmar Pasteka
2015-11-08 6:35 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Othmar Pasteka @ 2015-11-08 0:43 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, sudip, greg
Cc: devel, linux-fbdev, linux-kernel, Othmar Pasteka
checkpatch.pl says: CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Othmar Pasteka <pasteka@kabsi.at>
---
drivers/staging/sm750fb/sm750_cursor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index cab891c..0a41585 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -143,7 +143,7 @@ void hw_cursor_setData(struct lynx_cursor *cursor,
iowrite16(data, pbuffer);
/* assume pitch is 1,2,4,8,...*/
- if ((i+1) % pitch = 0) {
+ if ((i + 1) % pitch = 0) {
/* need a return */
pstart += offset;
pbuffer = pstart;
--
2.5.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] staging: sm750fb: add spaces around operator
2015-11-08 0:43 ` [PATCH 2/2] staging: sm750fb: add spaces around operator Othmar Pasteka
@ 2015-11-08 6:35 ` Dan Carpenter
2015-11-08 7:33 ` Othmar Pasteka
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2015-11-08 6:35 UTC (permalink / raw)
To: Othmar Pasteka
Cc: sudipm.mukherjee, teddy.wang, sudip, greg, devel, linux-fbdev,
linux-kernel
If it's a one line fix then just send it as a single patch.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] staging: sm750fb: add spaces around operator
2015-11-08 6:35 ` Dan Carpenter
@ 2015-11-08 7:33 ` Othmar Pasteka
2015-11-08 8:17 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Othmar Pasteka @ 2015-11-08 7:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: sudipm.mukherjee, teddy.wang, sudip, greg, devel, linux-fbdev,
linux-kernel
On Sun, Nov 08, 2015 at 09:35:08AM +0300, Dan Carpenter wrote:
> If it's a one line fix then just send it as a single patch.
It was two things, hence I made it a two-parter.
Should I send a new version or is it a note for next time?
Thanks,
Othmar Pasteka
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] staging: sm750fb: add spaces around operator
2015-11-08 7:33 ` Othmar Pasteka
@ 2015-11-08 8:17 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2015-11-08 8:17 UTC (permalink / raw)
To: Othmar Pasteka
Cc: sudipm.mukherjee, teddy.wang, sudip, greg, devel, linux-fbdev,
linux-kernel
On Sun, Nov 08, 2015 at 08:33:16AM +0100, Othmar Pasteka wrote:
> Should I send a new version or is it a note for next time?
Send a new version.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-08 8:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-08 0:43 [PATCH 1/2] staging: sm750fb: move opening brace to previous line Othmar Pasteka
2015-11-08 0:43 ` [PATCH 2/2] staging: sm750fb: add spaces around operator Othmar Pasteka
2015-11-08 6:35 ` Dan Carpenter
2015-11-08 7:33 ` Othmar Pasteka
2015-11-08 8:17 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).