From: Michael Turquette <mturquette@baylibre.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 03/24] clk: pwm: use pwm_get_xxx() helpers where appropriate
Date: Wed, 30 Dec 2015 21:03:58 +0000 [thread overview]
Message-ID: <20151230210358.19557.32933@quark.deferred.io> (raw)
In-Reply-To: <1447664207-24370-4-git-send-email-boris.brezillon@free-electrons.com>
Hi Boris,
Quoting Boris Brezillon (2015-11-16 00:56:26)
> diff --git a/drivers/clk/clk-pwm.c b/drivers/clk/clk-pwm.c
> index 328fcfc..b6306a2 100644
> --- a/drivers/clk/clk-pwm.c
> +++ b/drivers/clk/clk-pwm.c
> @@ -71,22 +71,23 @@ static int clk_pwm_probe(struct platform_device *pdev)
> if (IS_ERR(pwm))
> return PTR_ERR(pwm);
>
> - if (!pwm->period) {
> + if (!pwm_get_period((pwm))) {
The change itself looks fine, but the semantic patch added extra parens.
Can you remove them? After doing so feel free to add:
Acked-by: Michael Turquette <mturquette@baylibre.com>
next prev parent reply other threads:[~2015-12-30 21:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 8:56 [PATCH v4 00/24] pwm: add support for atomic update Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 01/24] pwm: rcar: make use of pwm_is_enabled() Boris Brezillon
2016-03-16 14:30 ` Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 02/24] pwm: use pwm_get_xxx() helpers where appropriate Boris Brezillon
2015-11-16 17:46 ` Joachim Eastwood
2015-11-16 18:06 ` Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 03/24] clk: " Boris Brezillon
2015-12-30 21:03 ` Michael Turquette [this message]
2015-11-16 8:56 ` [PATCH v4 04/24] hwmon: pwm-fan: " Boris Brezillon
2015-11-16 15:59 ` Guenter Roeck
2015-11-16 16:53 ` Boris Brezillon
2015-11-16 17:00 ` Guenter Roeck
2015-11-16 8:56 ` [PATCH v4 05/24] misc: max77693-haptic: " Boris Brezillon
2015-11-16 13:10 ` Krzysztof Kozlowski
2015-11-16 13:55 ` Boris Brezillon
2015-11-16 15:55 ` Guenter Roeck
2015-11-16 16:00 ` Boris Brezillon
2015-11-17 17:32 ` Dmitry Torokhov
2015-11-16 8:56 ` [PATCH v4 06/24] pwm: introduce default period and polarity concepts Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 07/24] pwm: use pwm_get/set_default_xxx() helpers where appropriate Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 08/24] leds: " Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 09/24] regulator: " Boris Brezillon
2015-11-16 10:55 ` Mark Brown
2015-11-16 12:23 ` Boris Brezillon
2015-11-16 18:42 ` Mark Brown
2015-11-16 19:28 ` Boris Brezillon
2015-12-02 10:37 ` Boris Brezillon
2015-12-30 11:01 ` Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 10/24] backlight: " Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 11/24] fbdev: " Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 12/24] misc: max77693: " Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 13/24] hwmon: pwm-fan: " Boris Brezillon
2015-11-16 16:00 ` Guenter Roeck
2015-11-16 8:56 ` [PATCH v4 14/24] clk: pwm: " Boris Brezillon
2015-12-30 21:05 ` Michael Turquette
2015-11-16 8:56 ` [PATCH v4 15/24] pwm: define a new pwm_state struct Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 16/24] pwm: move the enabled/disabled info to " Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 17/24] backlight: pwm_bl: remove useless call to pwm_set_period Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 18/24] pwm: declare a default PWM state Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 19/24] pwm: add the PWM initial state retrieval infra Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 20/24] pwm: add the core infrastructure to allow atomic update Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 21/24] pwm: add information about polarity, duty cycle and period to debugfs Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 22/24] pwm: rockchip: add initial state retrieval Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 23/24] pwm: rockchip: add support for atomic update Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 24/24] regulator: pwm: properly initialize the ->state field Boris Brezillon
2015-11-16 14:45 ` [PATCH v4 00/24] pwm: add support for atomic update Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151230210358.19557.32933@quark.deferred.io \
--to=mturquette@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).