From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: sebastian.lawniczak@yahoo.com
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Fix comments style
Date: Mon, 08 Feb 2016 02:54:26 +0000 [thread overview]
Message-ID: <20160208025426.GA10405@kroah.com> (raw)
In-Reply-To: <1449083891-29650-1-git-send-email-sebastian.lawniczak@yahoo.com>
On Wed, Dec 02, 2015 at 08:18:11PM +0100, sebastian.lawniczak@yahoo.com wrote:
> From: Sebastian Lawniczak <sebastian.lawniczak@yahoo.com>
>
> Fix warnings reported by checkpatch.pl in block comments.
>
> Signed-off-by: Sebastian Lawniczak <sebastian.lawniczak@yahoo.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 70 +++++++++++++++++++----------------
> 1 file changed, 39 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 0331d34..01ddf44 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -86,8 +86,10 @@ static void setMemoryClock(unsigned int frequency)
> return;
>
> if (frequency) {
> - /* Set the frequency to the maximum frequency that the DDR Memory can take
> - which is 336MHz. */
> + /*
> + * Set the frequency to the maximum frequency that the DDR Memory can take
> + * which is 336MHz.
> + */
It should look like:
/*
* Set the frequency to the maximum frequency that the DDR Memory can take
* which is 336MHz.
*/
So I can't take this patch, sorry.
Please fix it up and resend.
thanks,
greg k-h
parent reply other threads:[~2016-02-08 2:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1449083891-29650-1-git-send-email-sebastian.lawniczak@yahoo.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208025426.GA10405@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.lawniczak@yahoo.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).