From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 3/3] fbdev: omap2: panel-dpi: implement support for a vcc regulator
Date: Tue, 16 Feb 2016 13:48:26 +0000 [thread overview]
Message-ID: <20160216134826.GA32169@pengutronix.de> (raw)
In-Reply-To: <1450610002-10531-4-git-send-email-u.kleine-koenig@pengutronix.de>
Hello Tomi,
On Tue, Feb 16, 2016 at 03:00:00PM +0200, Tomi Valkeinen wrote:
> On 20/12/15 13:13, Uwe Kleine-König wrote:
> > @@ -223,6 +232,10 @@ static int panel_dpi_probe_of(struct platform_device *pdev)
> > if (IS_ERR(gpio))
> > return PTR_ERR(gpio);
> >
> > + ddata->vcc_supply = devm_regulator_get(&pdev->dev, "vcc");
> > + if (IS_ERR(ddata->vcc_supply))
> > + return PTR_ERR(ddata->vcc_supply);
>
> devm_regulator_get_optional()?
That would make the specification of a vcc supply obligatory IIUC. (Yes,
the semantic difference between regulator_get vs. regulator_get_optional
is reversed when comparing to gpio_get vs. gpio_get_optional.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-02-16 13:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 11:13 [PATCH v2 3/3] fbdev: omap2: panel-dpi: implement support for a vcc regulator Uwe Kleine-König
2016-02-16 13:00 ` Tomi Valkeinen
2016-02-16 13:48 ` Uwe Kleine-König [this message]
2016-02-26 10:13 ` Tomi Valkeinen
2016-02-26 12:10 ` Uwe Kleine-König
2016-02-26 12:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216134826.GA32169@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).