* Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS
2016-02-22 1:59 [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS Simon Horman
@ 2016-02-22 9:27 ` Geert Uytterhoeven
2016-02-22 12:24 ` Laurent Pinchart
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-02-22 9:27 UTC (permalink / raw)
To: linux-fbdev
On Mon, Feb 22, 2016 at 2:59 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
>
> This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
> appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS
2016-02-22 1:59 [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS Simon Horman
2016-02-22 9:27 ` Geert Uytterhoeven
@ 2016-02-22 12:24 ` Laurent Pinchart
2016-02-22 12:39 ` Geert Uytterhoeven
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2016-02-22 12:24 UTC (permalink / raw)
To: linux-fbdev
Hi Simon,
Thank you for the patch.
On Monday 22 February 2016 10:59:51 Simon Horman wrote:
> Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
>
> This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
> appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Wouldn't it make sense to drop the driver instead ? We have a DRM driver that
replaces it.
> ---
> drivers/video/fbdev/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Based on v4.5-rc1
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..936ebd4bcf73 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1985,7 +1985,7 @@ config FB_W100
>
> config FB_SH_MOBILE_LCDC
> tristate "SuperH Mobile LCDC framebuffer support"
> - depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
> + depends on FB && (SUPERH || ARCH_RENESAS) && HAVE_CLK
> depends on FB_SH_MOBILE_MERAM || !FB_SH_MOBILE_MERAM
> select FB_SYS_FILLRECT
> select FB_SYS_COPYAREA
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS
2016-02-22 1:59 [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS Simon Horman
2016-02-22 9:27 ` Geert Uytterhoeven
2016-02-22 12:24 ` Laurent Pinchart
@ 2016-02-22 12:39 ` Geert Uytterhoeven
2016-02-22 13:05 ` Laurent Pinchart
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-02-22 12:39 UTC (permalink / raw)
To: linux-fbdev
Hi Laurent,
On Mon, Feb 22, 2016 at 1:24 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Monday 22 February 2016 10:59:51 Simon Horman wrote:
>> Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
>>
>> This is part of an ongoing process to migrate from ARCH_SHMOBILE to
>> ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
>> appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
>>
>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Wouldn't it make sense to drop the driver instead ? We have a DRM driver that
> replaces it.
Does the DRM driver work on all hardware supported by the fbdev driver?
It's not only used on r8a7740/armadillo (through staging/board due to lack of
DT support), but also on many SH boards.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS
2016-02-22 1:59 [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS Simon Horman
` (2 preceding siblings ...)
2016-02-22 12:39 ` Geert Uytterhoeven
@ 2016-02-22 13:05 ` Laurent Pinchart
2016-02-23 0:11 ` Simon Horman
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2016-02-22 13:05 UTC (permalink / raw)
To: linux-fbdev
Hi Geert,
On Monday 22 February 2016 13:39:37 Geert Uytterhoeven wrote:
> On Mon, Feb 22, 2016 at 1:24 PM, Laurent Pinchart wrote:
> > On Monday 22 February 2016 10:59:51 Simon Horman wrote:
> >> Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
> >>
> >> This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> >> ARCH_RENESAS the motivation for which being that RENESAS seems to be a
> >> more appropriate name than SHMOBILE for the majority of Renesas ARM based
> >> SoCs.
> >>
> >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > Wouldn't it make sense to drop the driver instead ? We have a DRM driver
> > that replaces it.
>
> Does the DRM driver work on all hardware supported by the fbdev driver?
> It's not only used on r8a7740/armadillo (through staging/board due to lack
> of DT support), but also on many SH boards.
It's supposed to be a replacement (lacking support for SYS panels though), but
has obviously not been tested on SH boards.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS
2016-02-22 1:59 [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS Simon Horman
` (3 preceding siblings ...)
2016-02-22 13:05 ` Laurent Pinchart
@ 2016-02-23 0:11 ` Simon Horman
2016-02-23 7:41 ` Laurent Pinchart
2016-02-26 11:00 ` Tomi Valkeinen
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2016-02-23 0:11 UTC (permalink / raw)
To: linux-fbdev
On Mon, Feb 22, 2016 at 03:05:58PM +0200, Laurent Pinchart wrote:
> Hi Geert,
>
> On Monday 22 February 2016 13:39:37 Geert Uytterhoeven wrote:
> > On Mon, Feb 22, 2016 at 1:24 PM, Laurent Pinchart wrote:
> > > On Monday 22 February 2016 10:59:51 Simon Horman wrote:
> > >> Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
> > >>
> > >> This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> > >> ARCH_RENESAS the motivation for which being that RENESAS seems to be a
> > >> more appropriate name than SHMOBILE for the majority of Renesas ARM based
> > >> SoCs.
> > >>
> > >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > >
> > > Wouldn't it make sense to drop the driver instead ? We have a DRM driver
> > > that replaces it.
> >
> > Does the DRM driver work on all hardware supported by the fbdev driver?
> > It's not only used on r8a7740/armadillo (through staging/board due to lack
> > of DT support), but also on many SH boards.
>
> It's supposed to be a replacement (lacking support for SYS panels though), but
> has obviously not been tested on SH boards.
From my point of view it would be overreach to remove the driver as we
aren't in a position to test the SH boards.
We could stop using it on the Renesas ARM SoCs and in turn remove
ARCH_SHMOBILE/ARCH_RENESAS. Am I right in thinking that would only
effect the r8a7740/armadillo at this time?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS
2016-02-22 1:59 [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS Simon Horman
` (4 preceding siblings ...)
2016-02-23 0:11 ` Simon Horman
@ 2016-02-23 7:41 ` Laurent Pinchart
2016-02-26 11:00 ` Tomi Valkeinen
6 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2016-02-23 7:41 UTC (permalink / raw)
To: linux-fbdev
Hi Simon,
On Tuesday 23 February 2016 09:11:03 Simon Horman wrote:
> On Mon, Feb 22, 2016 at 03:05:58PM +0200, Laurent Pinchart wrote:
> > On Monday 22 February 2016 13:39:37 Geert Uytterhoeven wrote:
> >> On Mon, Feb 22, 2016 at 1:24 PM, Laurent Pinchart wrote:
> >>> On Monday 22 February 2016 10:59:51 Simon Horman wrote:
> >>>> Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
> >>>>
> >>>> This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> >>>> ARCH_RENESAS the motivation for which being that RENESAS seems to be
> >>>> a more appropriate name than SHMOBILE for the majority of Renesas ARM
> >>>> based SoCs.
> >>>>
> >>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>>
> >>> Wouldn't it make sense to drop the driver instead ? We have a DRM
> >>> driver that replaces it.
> >>
> >> Does the DRM driver work on all hardware supported by the fbdev driver?
> >> It's not only used on r8a7740/armadillo (through staging/board due to
> >> lack of DT support), but also on many SH boards.
> >
> > It's supposed to be a replacement (lacking support for SYS panels though),
> > but has obviously not been tested on SH boards.
>
> From my point of view it would be overreach to remove the driver as we
> aren't in a position to test the SH boards.
I'd be surprised if the driver still worked on those boards, but I like good
surprises :-)
> We could stop using it on the Renesas ARM SoCs and in turn remove
> ARCH_SHMOBILE/ARCH_RENESAS. Am I right in thinking that would only
> effect the r8a7740/armadillo at this time?
That's correct.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS
2016-02-22 1:59 [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS Simon Horman
` (5 preceding siblings ...)
2016-02-23 7:41 ` Laurent Pinchart
@ 2016-02-26 11:00 ` Tomi Valkeinen
6 siblings, 0 replies; 8+ messages in thread
From: Tomi Valkeinen @ 2016-02-26 11:00 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1.1: Type: text/plain, Size: 1116 bytes --]
On 22/02/16 03:59, Simon Horman wrote:
> Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
>
> This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
> appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/video/fbdev/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Based on v4.5-rc1
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..936ebd4bcf73 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1985,7 +1985,7 @@ config FB_W100
>
> config FB_SH_MOBILE_LCDC
> tristate "SuperH Mobile LCDC framebuffer support"
> - depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
> + depends on FB && (SUPERH || ARCH_RENESAS) && HAVE_CLK
> depends on FB_SH_MOBILE_MERAM || !FB_SH_MOBILE_MERAM
> select FB_SYS_FILLRECT
> select FB_SYS_COPYAREA
>
Thanks, queued for 4.6.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread