From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/7 v2] video: ARM CLCD: support pads connected in reverse order
Date: Tue, 23 Feb 2016 10:35:18 +0000 [thread overview]
Message-ID: <20160223103518.GG19428@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1456221704-5792-5-git-send-email-linus.walleij@linaro.org>
On Tue, Feb 23, 2016 at 11:01:41AM +0100, Linus Walleij wrote:
> - if (var->red.offset = 0)
> - val &= ~CNTL_BGR;
> - else
> - val |= CNTL_BGR;
> + if (!fb->panel->bgr_connection) {
> + if (var->red.offset = 0)
> + val &= ~CNTL_BGR;
> + else
> + val |= CNTL_BGR;
> + } else {
> + if (var->blue.offset = 0)
> + val &= ~CNTL_BGR;
> + else
> + val |= CNTL_BGR;
> + }
if (fb->panel->bgr_connection)
val ^= CNTL_BGR;
is a shorter way to write the above, and probably easier on the compiler
too.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-02-23 10:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 10:01 [PATCH 0/7] video: ARM CLCD: non-controversial parts Linus Walleij
2016-02-23 10:01 ` [PATCH 1/7 RESEND] video: ARM CLCD: runtime check for Versatile Linus Walleij
2016-04-15 11:47 ` Linus Walleij
2016-04-18 9:10 ` Tomi Valkeinen
2016-02-23 10:01 ` [PATCH 2/7 v2] video: ARM CLCD: backlight support for OF Linus Walleij
2016-02-23 10:01 ` [PATCH 3/7 v2] video: ARM CLCD: support DT signal inversion flags Linus Walleij
2016-02-26 10:34 ` Tomi Valkeinen
2016-03-07 4:45 ` Linus Walleij
2016-02-23 10:01 ` [PATCH 4/7 v2] video: ARM CLCD: support pads connected in reverse order Linus Walleij
2016-02-23 10:35 ` Russell King - ARM Linux [this message]
2016-02-25 19:34 ` Linus Walleij
2016-02-23 10:01 ` [PATCH 5/7 v2] video: ARM CLCD: support Nomadik variant Linus Walleij
2016-02-23 10:01 ` [PATCH 6/7 v2] video: ARM CLCD: add special board and panel hooks for Nomadik Linus Walleij
2016-02-23 10:01 ` [PATCH 7/7 v2] video: ARM CLCD: add special panel hook for Versatiles Linus Walleij
2016-02-25 19:35 ` [PATCH 0/7] video: ARM CLCD: non-controversial parts Linus Walleij
2016-02-26 10:20 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223103518.GG19428@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).