From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Date: Sun, 17 Apr 2016 12:45:48 +0000 Subject: Re: [PATCH v5 13/24] input: misc: max8997: explicitly apply PWM config extracted from pwm_args Message-Id: <20160417124548.GE33215@dtor-ws> List-Id: References: <1460661464-11216-1-git-send-email-boris.brezillon@free-electrons.com> <1460661464-11216-14-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1460661464-11216-14-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Boris Brezillon Cc: Thierry Reding , linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Turquette , Stephen Boyd , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown , Liam Girdwood , Kamil Debski , lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, Jean Delvare , Guenter Roeck , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Joachim Eastwood , Thomas Petazzoni , Heiko Stuebner , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jingoo Han , Lee Jones On Thu, Apr 14, 2016 at 09:17:33PM +0200, Boris Brezillon wrote: > Call pwm_apply_args() just after requesting the PWM device so that the > polarity and period are initialized according to the information provided > in pwm_args. > > This is an intermediate state, and pwm_apply_args() should be dropped as > soon as the atomic PWM infrastructure is in place and the driver makes > use of it. > > Signed-off-by: Boris Brezillon > --- > drivers/input/misc/max8997_haptic.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/input/misc/max8997_haptic.c b/drivers/input/misc/max8997_haptic.c > index a806ba3..bf17f65 100644 > --- a/drivers/input/misc/max8997_haptic.c > +++ b/drivers/input/misc/max8997_haptic.c > @@ -304,6 +304,12 @@ static int max8997_haptic_probe(struct platform_device *pdev) > error); > goto err_free_mem; > } > + > + /* > + * FIXME: pwm_apply_args() should be removed when switching to > + * the atomic PWM API. > + */ > + pwm_apply_args(chip->pwm); I do not understand. We did not fetch/modify any args, what are we applying and why? Especially since we saying we want to remove this later. Thanks. -- Dmitry