From: Wolfram Sang <wsa@the-dreams.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Wolfram Sang <wsa-dev@sang-engineering.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable
Date: Sat, 13 Aug 2016 18:45:25 +0000 [thread overview]
Message-ID: <20160813184525.GA1690@katana> (raw)
In-Reply-To: <20160813183913.30635-1-paul.gortmaker@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
On Sat, Aug 13, 2016 at 02:39:13PM -0400, Paul Gortmaker wrote:
> In commit 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't
> print error when adding adapter fails") the users of the variable
> were removed, resulting in:
>
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function ‘mb862xx_i2c_init’:
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning: unused variable ‘ret’ [-Wunused-variable]
> int ret;
> ^
>
> ...so here we remove the variable as well.
>
> Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails)"
> Cc: Wolfram Sang <wsa-dev@sang-engineering.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
Acked-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Thanks! I wonder how this slipped through my and the buildbot checks.
Will investigate...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-13 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 12:28 [PATCH] video: fbdev: mb862xx: mb862xx-i2c.c: Cleaning up variable that is never used Rickard Strandqvist
2014-07-06 18:38 ` Rickard Strandqvist
2016-08-13 18:39 ` [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable Paul Gortmaker
2016-08-13 18:45 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160813184525.GA1690@katana \
--to=wsa@the-dreams.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tomi.valkeinen@ti.com \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).