[PATCH] video: fbdev: mb862xx: mb862xx-i2c.c: Cleaning up variable that is never used

[PATCH] video: fbdev: mb862xx: mb862xx-i2c.c: Cleaning up variable that is never used

[Rickard Strandqvist]

From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/video/fbdev/mb862xx/mb862xx-i2c.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index c87e17a..6b9769f 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -20,7 +20,6 @@
 
 static int mb862xx_i2c_wait_event(struct i2c_adapter *adap)
 {
-	struct mb862xxfb_par *par = adap->algo_data;
 	u32 reg;
 
 	do {
@@ -48,8 +47,6 @@ static int mb862xx_i2c_do_address(struct i2c_adapter *adap, int addr)
 
 static int mb862xx_i2c_write_byte(struct i2c_adapter *adap, u8 byte)
 {
-	struct mb862xxfb_par *par = adap->algo_data;
-
 	outreg(i2c, GC_I2C_DAR, byte);
 	outreg(i2c, GC_I2C_BCR, I2C_START);
 	if (!mb862xx_i2c_wait_event(adap))
@@ -59,8 +56,6 @@ static int mb862xx_i2c_write_byte(struct i2c_adapter *adap, u8 byte)
 
 static int mb862xx_i2c_read_byte(struct i2c_adapter *adap, u8 *byte, int last)
 {
-	struct mb862xxfb_par *par = adap->algo_data;
-
 	outreg(i2c, GC_I2C_BCR, I2C_START | (last ? 0 : I2C_ACK));
 	if (!mb862xx_i2c_wait_event(adap))
 		return 0;
-- 
1.7.10.4

[PATCH] video: fbdev: mb862xx: mb862xx-i2c.c: Cleaning up variable that is never used

[Rickard Strandqvist]

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/video/fbdev/mb862xx/mb862xx-i2c.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index c87e17a..6b9769f 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -20,7 +20,6 @@
 
 static int mb862xx_i2c_wait_event(struct i2c_adapter *adap)
 {
-	struct mb862xxfb_par *par = adap->algo_data;
 	u32 reg;
 
 	do {
@@ -48,8 +47,6 @@ static int mb862xx_i2c_do_address(struct i2c_adapter *adap, int addr)
 
 static int mb862xx_i2c_write_byte(struct i2c_adapter *adap, u8 byte)
 {
-	struct mb862xxfb_par *par = adap->algo_data;
-
 	outreg(i2c, GC_I2C_DAR, byte);
 	outreg(i2c, GC_I2C_BCR, I2C_START);
 	if (!mb862xx_i2c_wait_event(adap))
@@ -59,8 +56,6 @@ static int mb862xx_i2c_write_byte(struct i2c_adapter *adap, u8 byte)
 
 static int mb862xx_i2c_read_byte(struct i2c_adapter *adap, u8 *byte, int last)
 {
-	struct mb862xxfb_par *par = adap->algo_data;
-
 	outreg(i2c, GC_I2C_BCR, I2C_START | (last ? 0 : I2C_ACK));
 	if (!mb862xx_i2c_wait_event(adap))
 		return 0;
-- 
1.7.10.4

[PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable

[Paul Gortmaker]

In commit 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't
print error when adding adapter fails") the users of the variable
were removed, resulting in:

drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function ‘mb862xx_i2c_init’:
drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning: unused variable ‘ret’ [-Wunused-variable]
  int ret;
      ^

...so here we remove the variable as well.

Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails)"
Cc: Wolfram Sang <wsa-dev@sang-engineering.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

[Feel free to squash this into the original if you happen to be rebasing]

 drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index 76d206857e3e..ba96c44f2761 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -157,8 +157,6 @@ static struct i2c_adapter mb862xx_i2c_adapter = {
 
 int mb862xx_i2c_init(struct mb862xxfb_par *par)
 {
-	int ret;
-
 	mb862xx_i2c_adapter.algo_data = par;
 	par->adap = &mb862xx_i2c_adapter;
 
-- 
2.8.4

Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: delete now unused "int ret" variable

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

On Sat, Aug 13, 2016 at 02:39:13PM -0400, Paul Gortmaker wrote:
> In commit 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't
> print error when adding adapter fails") the users of the variable
> were removed, resulting in:
> 
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c: In function ‘mb862xx_i2c_init’:
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c:160:6: warning: unused variable ‘ret’ [-Wunused-variable]
>   int ret;
>       ^
> 
> ...so here we remove the variable as well.
> 
> Fixes: 6b610e004baf ("video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails)"
> Cc: Wolfram Sang <wsa-dev@sang-engineering.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---

Acked-by: Wolfram Sang <wsa-dev@sang-engineering.com>

Thanks! I wonder how this slipped through my and the buildbot checks.
Will investigate...


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]