From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Wed, 31 Aug 2016 12:25:14 +0000 Subject: Re: [PATCH 1/6] backlight: pwm_bl: Handle gpio that can sleep Message-Id: <20160831122514.GE9415@dell> List-Id: References: <20160831081817.5191-1-maxime.ripard@free-electrons.com> <20160831081817.5191-2-maxime.ripard@free-electrons.com> In-Reply-To: <20160831081817.5191-2-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Maxime Ripard Cc: Linus Walleij , Chen-Yu Tsai , Jingoo Han , Tomi Valkeinen , Daniel Vetter , David Airlie , Thierry Reding , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Mylene Josserand , Thomas Petazzoni , Alexander Kaplan On Wed, 31 Aug 2016, Maxime Ripard wrote: > Some backlight GPIOs might be connected to some i2c based expanders whose > access might sleep. >=20 > Since it's not in any critical path, use the cansleep variant of the GPIO > API. >=20 > Signed-off-by: Maxime Ripard > --- > drivers/video/backlight/pwm_bl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/p= wm_bl.c > index b2b366bb0f97..12614006211e 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -55,7 +55,7 @@ static void pwm_backlight_power_on(struct pwm_bl_data *= pb, int brightness) > dev_err(pb->dev, "failed to enable power supply\n"); > =20 > if (pb->enable_gpio) > - gpiod_set_value(pb->enable_gpio, 1); > + gpiod_set_value_cansleep(pb->enable_gpio, 1); > =20 > pwm_enable(pb->pwm); > pb->enabled =3D true; > @@ -70,7 +70,7 @@ static void pwm_backlight_power_off(struct pwm_bl_data = *pb) > pwm_disable(pb->pwm); > =20 > if (pb->enable_gpio) > - gpiod_set_value(pb->enable_gpio, 0); > + gpiod_set_value_cansleep(pb->enable_gpio, 0); > =20 > regulator_disable(pb->power_supply); > pb->enabled =3D false; --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog