From: Moshe Green <mgmoshes@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: sm750fb: fix line length coding style issues in ddk750_chip.c
Date: Thu, 15 Sep 2016 18:56:32 +0000 [thread overview]
Message-ID: <20160915185632.GA17632@gmail.com> (raw)
In-Reply-To: <20160912111635.GA12026@kroah.com>
On Mon, Sep 12, 2016 at 01:16:35PM +0200, Greg KH wrote:
> On Sun, Sep 04, 2016 at 09:03:27PM +0300, Moshe Green wrote:
> > Fix multiple line length warnings found by the checkpatch.pl tool
> > in ddk750_chip.c.
> >
> > Signed-off-by: Moshe Green <mgmoshes@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_chip.c | 18 ++++++++++++------
> > 1 file changed, 12 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> > index c1356bb..76aaeaa 100644
> > --- a/drivers/staging/sm750fb/ddk750_chip.c
> > +++ b/drivers/staging/sm750fb/ddk750_chip.c
> > @@ -71,7 +71,7 @@ static void setChipClock(unsigned int frequency)
> > pll.clockType = MXCLK_PLL;
> >
> > /*
> > - * Call calcPllValue() to fill up the other fields for PLL structure.
> > + * Call calcPllValue() to fill the other fields of PLL structure.
> > * Sometime, the chip cannot set up the exact clock required by User.
> > * Return value from calcPllValue() gives the actual possible clock.
>
> You only changed one sentance here, please fix the whole block.
>
> thanks,
>
> greg k-h
Will do.
Thanks
next prev parent reply other threads:[~2016-09-15 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 18:03 [PATCH 1/2] staging: sm750fb: fix line length coding style issues in ddk750_chip.c Moshe Green
2016-09-04 18:04 ` [PATCH 2/2] staging: sm750fb: fix block comment style and spelling " Moshe Green
2016-09-12 11:17 ` Greg KH
2016-09-15 18:59 ` Moshe Green
2016-09-12 11:16 ` [PATCH 1/2] staging: sm750fb: fix line length coding style " Greg KH
2016-09-15 18:56 ` Moshe Green [this message]
2016-09-15 20:15 ` Moshe Green
2016-09-15 20:16 ` [PATCH 2/2] staging: sm750fb: fix block comment style and spelling " Moshe Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915185632.GA17632@gmail.com \
--to=mgmoshes@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).