From: Greg KH <gregkh@linuxfoundation.org>
To: Moshe Green <mgmoshes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c
Date: Sun, 02 Oct 2016 09:47:47 +0000 [thread overview]
Message-ID: <20161002094747.GA27462@kroah.com> (raw)
In-Reply-To: <bbdf9102afd4b72160d274a575a2f1eea5580afb.1475387062.git.mgmoshes@gmail.com>
On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote:
> Rename CamelCased macro roundedDiv to rounded_div.
>
> This issue was found by checkpatch.pl
>
> Signed-off-by: Moshe Green <mgmoshes@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 3a0afe1..e4efe91 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -7,7 +7,7 @@
> #include "ddk750_power.h"
>
> /* n / d + 1 / 2 = (2n + d) / 2d */
> -#define roundedDiv(num, denom) ((2 * (num) + (denom)) / (2 * (denom)))
> +#define rounded_div(num, denom) ((2 * (num) + (denom)) / (2 * (denom)))
Shouldn't you use the in-kernel function for this instead?
next prev parent reply other threads:[~2016-10-02 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-02 5:48 [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c Moshe Green
2016-10-02 9:47 ` Greg KH [this message]
2016-10-02 10:43 ` Moshe Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161002094747.GA27462@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgmoshes@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).