* [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c
@ 2016-10-02 5:48 Moshe Green
2016-10-02 9:47 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Moshe Green @ 2016-10-02 5:48 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh; +Cc: linux-fbdev, devel, linux-kernel
Rename CamelCased macro roundedDiv to rounded_div.
This issue was found by checkpatch.pl
Signed-off-by: Moshe Green <mgmoshes@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 3a0afe1..e4efe91 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -7,7 +7,7 @@
#include "ddk750_power.h"
/* n / d + 1 / 2 = (2n + d) / 2d */
-#define roundedDiv(num, denom) ((2 * (num) + (denom)) / (2 * (denom)))
+#define rounded_div(num, denom) ((2 * (num) + (denom)) / (2 * (denom)))
#define MHz(x) ((x) * 1000000)
logical_chip_type_t sm750_get_chip_type(void)
@@ -102,7 +102,7 @@ static void setMemoryClock(unsigned int frequency)
frequency = MHz(336);
/* Calculate the divisor */
- divisor = roundedDiv(get_mxclk_freq(), frequency);
+ divisor = rounded_div(get_mxclk_freq(), frequency);
/* Set the corresponding divisor in the register. */
reg = PEEK32(CURRENT_GATE) & ~CURRENT_GATE_M2XCLK_MASK;
@@ -152,7 +152,7 @@ static void setMasterClock(unsigned int frequency)
frequency = MHz(190);
/* Calculate the divisor */
- divisor = roundedDiv(get_mxclk_freq(), frequency);
+ divisor = rounded_div(get_mxclk_freq(), frequency);
/* Set the corresponding divisor in the register. */
reg = PEEK32(CURRENT_GATE) & ~CURRENT_GATE_MCLK_MASK;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c
2016-10-02 5:48 [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c Moshe Green
@ 2016-10-02 9:47 ` Greg KH
2016-10-02 10:43 ` Moshe Green
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2016-10-02 9:47 UTC (permalink / raw)
To: Moshe Green
Cc: sudipm.mukherjee, teddy.wang, devel, linux-fbdev, linux-kernel
On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote:
> Rename CamelCased macro roundedDiv to rounded_div.
>
> This issue was found by checkpatch.pl
>
> Signed-off-by: Moshe Green <mgmoshes@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 3a0afe1..e4efe91 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -7,7 +7,7 @@
> #include "ddk750_power.h"
>
> /* n / d + 1 / 2 = (2n + d) / 2d */
> -#define roundedDiv(num, denom) ((2 * (num) + (denom)) / (2 * (denom)))
> +#define rounded_div(num, denom) ((2 * (num) + (denom)) / (2 * (denom)))
Shouldn't you use the in-kernel function for this instead?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c
2016-10-02 9:47 ` Greg KH
@ 2016-10-02 10:43 ` Moshe Green
0 siblings, 0 replies; 3+ messages in thread
From: Moshe Green @ 2016-10-02 10:43 UTC (permalink / raw)
To: Greg KH; +Cc: Sudip Mukherjee, Teddy Wang, linux-fbdev, devel, linux-kernel
On Sun, Oct 02, 2016 at 11:47:47AM +0200, Greg KH wrote:
> On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote:
> > Rename CamelCased macro roundedDiv to rounded_div.
> >
> > This issue was found by checkpatch.pl
> >
> > Signed-off-by: Moshe Green <mgmoshes@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_chip.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> > index 3a0afe1..e4efe91 100644
> > --- a/drivers/staging/sm750fb/ddk750_chip.c
> > +++ b/drivers/staging/sm750fb/ddk750_chip.c
> > @@ -7,7 +7,7 @@
> > #include "ddk750_power.h"
> >
> > /* n / d + 1 / 2 = (2n + d) / 2d */
> > -#define roundedDiv(num, denom) ((2 * (num) + (denom)) / (2 * (denom)))
> > +#define rounded_div(num, denom) ((2 * (num) + (denom)) / (2 * (denom)))
>
> Shouldn't you use the in-kernel function for this instead?
(I thought briefly of looking for an existing implementation but
then chose not to since I wanted to minimize the functional changes in my patches
for the time being. Additionally I was wary of using a different implementation for a
division operation.)
I'll submit a patch that will replace the local implemetaion of rounded
division with the in-kernel implementation (I'm assuming you're
referring to the DIV_ROUND_CLOSEST macro from include/linux/kernel.h).
Thanks
Moshe Green
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-02 10:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-02 5:48 [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c Moshe Green
2016-10-02 9:47 ` Greg KH
2016-10-02 10:43 ` Moshe Green
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).