From: Edward Lipinsky <ellipinsky@gmail.com>
To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, sudip@vectorindia.org
Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] staging: sm750fb: Fix printk() style warning
Date: Sun, 02 Oct 2016 18:05:05 +0000 [thread overview]
Message-ID: <20161002180505.GA19813@gmail.com> (raw)
This patch fixes the checkpatch.pl warning:
WARNING: printk() should include KERN_ facility level
Signed-off-by: Edward Lipinsky <ellipinsky@gmail.com>
---
drivers/staging/sm750fb/ddk750_help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..e72a29c 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
devId750 = devId;
revId750 = revId;
if (revId = 0xfe)
- printk("found sm750le\n");
+ pr_info("found sm750le\n");
}
--
2.7.4
next reply other threads:[~2016-10-02 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-02 18:05 Edward Lipinsky [this message]
2016-10-02 18:13 ` [PATCH] staging: sm750fb: Fix printk() style warning Greg KH
2016-10-07 4:27 ` Edward Lipinsky
2016-10-07 9:12 ` Mike Rapoport
2016-10-10 14:31 ` Edward Lipinsky
2016-10-13 14:39 ` Mike Rapoport
2016-10-14 5:18 ` Edward Lipinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161002180505.GA19813@gmail.com \
--to=ellipinsky@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudip@vectorindia.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).