* [PATCH v2] video: fbdev: sh_mobile_lcdcfb: use designated initializers @ 2016-12-20 20:10 ` Kees Cook 2017-01-11 12:50 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Kees Cook @ 2016-12-20 20:10 UTC (permalink / raw) To: linux-kernel; +Cc: Geert Uytterhoeven, Bartlomiej Zolnierkiewicz, linux-fbdev Prepare to mark sensitive kernel structures for randomization by making sure they're using designated initializers. These were identified during allyesconfig builds of x86, arm, and arm64, with most initializer fixes extracted from grsecurity. Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v2: - vertical columns, Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index 82c0a8caa9b8..93469f94c09d 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -439,9 +439,9 @@ static unsigned long lcdc_sys_read_data(void *handle) } static struct sh_mobile_lcdc_sys_bus_ops sh_mobile_lcdc_sys_bus_ops = { - lcdc_sys_write_index, - lcdc_sys_write_data, - lcdc_sys_read_data, + .write_index = lcdc_sys_write_index, + .write_data = lcdc_sys_write_data, + .read_data = lcdc_sys_read_data, }; static int sh_mobile_lcdc_sginit(struct fb_info *info, -- 2.7.4 -- Kees Cook Nexus Security ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] video: fbdev: sh_mobile_lcdcfb: use designated initializers 2016-12-20 20:10 ` [PATCH v2] video: fbdev: sh_mobile_lcdcfb: use designated initializers Kees Cook @ 2017-01-11 12:50 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-01-11 12:50 UTC (permalink / raw) To: Kees Cook; +Cc: linux-kernel, Geert Uytterhoeven, linux-fbdev Hi, On Tuesday, December 20, 2016 12:10:49 PM Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook <keescook@chromium.org> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, queued for 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > v2: > - vertical columns, Bartlomiej Zolnierkiewicz > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c > index 82c0a8caa9b8..93469f94c09d 100644 > --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -439,9 +439,9 @@ static unsigned long lcdc_sys_read_data(void *handle) > } > > static struct sh_mobile_lcdc_sys_bus_ops sh_mobile_lcdc_sys_bus_ops = { > - lcdc_sys_write_index, > - lcdc_sys_write_data, > - lcdc_sys_read_data, > + .write_index = lcdc_sys_write_index, > + .write_data = lcdc_sys_write_data, > + .read_data = lcdc_sys_read_data, > }; > > static int sh_mobile_lcdc_sginit(struct fb_info *info, ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-11 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20161220201053epcas1p3440c5c2973397422318bae039948af8e@epcas1p3.samsung.com>
2016-12-20 20:10 ` [PATCH v2] video: fbdev: sh_mobile_lcdcfb: use designated initializers Kees Cook
2017-01-11 12:50 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).