From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
mhocko@suse.com, linux-mm@kvack.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc: Wait for oom_lock before retrying.
Date: Fri, 13 Jan 2017 03:53:07 +0000 [thread overview]
Message-ID: <20170113035307.GD9360@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170113025212.GB9360@jagdpanzerIV.localdomain>
On (01/13/17 11:52), Sergey Senozhatsky wrote:
[..]
> and we really don't want to cond_resched() when we are in panic.
> that's why console_flush_on_panic() sets it to zero explicitly.
>
> console_trylock() checks oops_in_progress, so re-taking the semaphore
> when we are in
>
> panic()
> console_flush_on_panic()
> console_unlock()
> console_trylock()
>
> should be OK. as well as doing get_console_conditional_schedule() somewhere
> in console driver code.
d'oh... no, this is false. console_flush_on_panic() is called after we
bust_spinlocks(0), BUT with local IRQs disabled. so console_trylock()
would still set console_may_schedule to 0.
-ss
next prev parent reply other threads:[~2017-01-13 3:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161220153948.GA575@tigerII.localdomain>
[not found] ` <201612221927.BGE30207.OSFJMFLFOHQtOV@I-love.SAKURA.ne.jp>
[not found] ` <20161222134250.GE413@tigerII.localdomain>
[not found] ` <201612222301.AFG57832.QOFMSVFOJHLOtF@I-love.SAKURA.ne.jp>
[not found] ` <20161222140930.GF413@tigerII.localdomain>
[not found] ` <201612261954.FJE69201.OFLVtFJSQFOHMO@I-love.SAKURA.ne.jp>
2016-12-26 11:34 ` [PATCH] mm/page_alloc: Wait for oom_lock before retrying Sergey Senozhatsky
2017-01-12 13:10 ` Petr Mladek
2017-01-13 2:52 ` Sergey Senozhatsky
2017-01-13 3:53 ` Sergey Senozhatsky [this message]
2017-01-13 11:15 ` Petr Mladek
2017-01-13 11:14 ` Petr Mladek
2017-01-12 14:18 ` Petr Mladek
2017-01-13 2:28 ` Sergey Senozhatsky
2017-01-13 11:03 ` Petr Mladek
2017-01-13 11:50 ` Sergey Senozhatsky
2017-01-13 12:15 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113035307.GD9360@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).