* [PATCH] video: fbdev: pmag-ba-fb: remove incorrect __exit markups @ 2017-02-25 19:24 ` Dmitry Torokhov 2017-03-20 16:48 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Dmitry Torokhov @ 2017-02-25 19:24 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Maciej W. Rozycki, Tomi Valkeinen, linux-fbdev, linux-kernel Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/video/fbdev/pmag-ba-fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/pmag-ba-fb.c b/drivers/video/fbdev/pmag-ba-fb.c index 5872bc4af3ce..f49317f137ec 100644 --- a/drivers/video/fbdev/pmag-ba-fb.c +++ b/drivers/video/fbdev/pmag-ba-fb.c @@ -235,7 +235,7 @@ static int pmagbafb_probe(struct device *dev) return err; } -static int __exit pmagbafb_remove(struct device *dev) +static int pmagbafb_remove(struct device *dev) { struct tc_dev *tdev = to_tc_dev(dev); struct fb_info *info = dev_get_drvdata(dev); @@ -270,7 +270,7 @@ static struct tc_driver pmagbafb_driver = { .name = "pmagbafb", .bus = &tc_bus_type, .probe = pmagbafb_probe, - .remove = __exit_p(pmagbafb_remove), + .remove = pmagbafb_remove, }, }; -- 2.11.0.483.g087da7b7c-goog -- Dmitry ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: pmag-ba-fb: remove incorrect __exit markups 2017-02-25 19:24 ` [PATCH] video: fbdev: pmag-ba-fb: remove incorrect __exit markups Dmitry Torokhov @ 2017-03-20 16:48 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-03-20 16:48 UTC (permalink / raw) To: Dmitry Torokhov Cc: Maciej W. Rozycki, Tomi Valkeinen, linux-fbdev, linux-kernel On Saturday, February 25, 2017 11:24:46 AM Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically disables sysfs bind/unbind > attributes. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Patch queued for 4.12, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-20 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170225192451epcas2p45e9994c5b5618eb73560680041016efc@epcas2p4.samsung.com>
2017-02-25 19:24 ` [PATCH] video: fbdev: pmag-ba-fb: remove incorrect __exit markups Dmitry Torokhov
2017-03-20 16:48 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).