* [PATCH] video: fbdev: pmag-aa-fb: remove incorrect __exit markups
@ 2017-03-01 23:31 ` Dmitry Torokhov
2017-03-20 16:49 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2017-03-01 23:31 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-fbdev, linux-kernel
Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/video/fbdev/pmag-aa-fb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/pmag-aa-fb.c b/drivers/video/fbdev/pmag-aa-fb.c
index ffe2dd482f84..39922f072db4 100644
--- a/drivers/video/fbdev/pmag-aa-fb.c
+++ b/drivers/video/fbdev/pmag-aa-fb.c
@@ -247,7 +247,7 @@ static int pmagaafb_probe(struct device *dev)
return err;
}
-static int __exit pmagaafb_remove(struct device *dev)
+static int pmagaafb_remove(struct device *dev)
{
struct tc_dev *tdev = to_tc_dev(dev);
struct fb_info *info = dev_get_drvdata(dev);
@@ -280,7 +280,7 @@ static struct tc_driver pmagaafb_driver = {
.name = "pmagaafb",
.bus = &tc_bus_type,
.probe = pmagaafb_probe,
- .remove = __exit_p(pmagaafb_remove),
+ .remove = pmagaafb_remove,
},
};
--
2.12.0.rc1.440.g5b76565f74-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: pmag-aa-fb: remove incorrect __exit markups
2017-03-01 23:31 ` [PATCH] video: fbdev: pmag-aa-fb: remove incorrect __exit markups Dmitry Torokhov
@ 2017-03-20 16:49 ` Bartlomiej Zolnierkiewicz
2017-03-23 11:48 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-03-20 16:49 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-fbdev, linux-kernel
On Wednesday, March 01, 2017 03:31:09 PM Dmitry Torokhov wrote:
> Even if bus is not hot-pluggable, devices can be unbound from the
> driver via sysfs, so we should not be using __exit annotations on
> remove() methods. The only exception is drivers registered with
> platform_driver_probe() which specifically disables sysfs bind/unbind
> attributes.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Patch queued for 4.12, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: pmag-aa-fb: remove incorrect __exit markups
2017-03-20 16:49 ` Bartlomiej Zolnierkiewicz
@ 2017-03-23 11:48 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2017-03-23 11:48 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Dmitry Torokhov, linux-fbdev, linux-kernel
On Mon, 20 Mar 2017, Bartlomiej Zolnierkiewicz wrote:
> > Even if bus is not hot-pluggable, devices can be unbound from the
> > driver via sysfs, so we should not be using __exit annotations on
> > remove() methods. The only exception is drivers registered with
> > platform_driver_probe() which specifically disables sysfs bind/unbind
> > attributes.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Patch queued for 4.12, thanks.
Thanks!
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-23 11:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170301233114epcas2p3a6fa255ce9b90f7715ab7f7f89866ec9@epcas2p3.samsung.com>
2017-03-01 23:31 ` [PATCH] video: fbdev: pmag-aa-fb: remove incorrect __exit markups Dmitry Torokhov
2017-03-20 16:49 ` Bartlomiej Zolnierkiewicz
2017-03-23 11:48 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).