From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations
Date: Tue, 07 Mar 2017 17:39:35 +0000 [thread overview]
Message-ID: <20170307173935.GL4171@mwanda> (raw)
In-Reply-To: <20170305112450.9066-2-arushisinghal19971997@gmail.com>
On Sun, Mar 05, 2017 at 04:54:48PM +0530, Arushi Singhal wrote:
> This patch fixes the warnings reported by checkpatch.pl
> for please use a blank line after function/struct/union/enum
> declarations.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_display.h | 1 +
> drivers/staging/sm750fb/ddk750_mode.h | 2 ++
> drivers/staging/sm750fb/ddk750_power.h | 1 +
> drivers/staging/sm750fb/sm750_cursor.c | 3 +++
> 4 files changed, 7 insertions(+)
>
> diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h
> index e2a3f84ca4c5..8bf22e4f0d8b 100644
> --- a/drivers/staging/sm750fb/ddk750_display.h
> +++ b/drivers/staging/sm750fb/ddk750_display.h
> @@ -100,6 +100,7 @@ typedef enum _disp_output_t {
> do_CRT_PRI = CRT_2_PRI | PRI_TP_ON | DPMS_ON | DAC_ON,
> do_CRT_SEC = CRT_2_SEC | SEC_TP_ON | DPMS_ON | DAC_ON,
> }
> +
> disp_output_t;
Nah... This is a typedef and this change makes it even worse. It
should be on the same line as the }.
} disp_output_t;
But actually this typedef is not allowed.
regards,
dan carpenter
next prev parent reply other threads:[~2017-03-07 17:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 11:36 [PATCH 0/3] multiple checkpatch issues Arushi Singhal
2017-03-05 11:36 ` [PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations Arushi Singhal
2017-03-06 19:34 ` Geert Uytterhoeven
2017-03-07 17:39 ` Dan Carpenter [this message]
2017-03-05 11:36 ` [PATCH 2/3] staging: sm750fb: function prototype argument should have an identifier name Arushi Singhal
2017-03-05 11:36 ` [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis Arushi Singhal
2017-03-07 17:44 ` Dan Carpenter
2017-03-05 13:39 ` [PATCH 0/3] multiple checkpatch issues Joe Perches
2017-03-10 21:57 ` Arushi Singhal
2017-03-10 21:57 ` [PATCH 1/3] staging: sm750fb: function prototype argument should have an identifier name Arushi Singhal
2017-03-10 21:57 ` [PATCH 2/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations Arushi Singhal
2017-03-10 21:58 ` [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis Arushi Singhal
2017-03-10 22:05 ` [PATCH 0/3] multiple checkpatch issues Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307173935.GL4171@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).