From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Antonino Daplas <adaplas@gmail.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: i810: remove incorrect __exit markups
Date: Mon, 20 Mar 2017 18:42:56 +0000 [thread overview]
Message-ID: <20170320184256.GB23083@dtor-ws> (raw)
In-Reply-To: <1880466.B5ZPIScV32@amdc3058>
Hi Bartlomiej,
On Mon, Mar 20, 2017 at 06:19:17PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday, March 01, 2017 05:31:01 PM Dmitry Torokhov wrote:
> > Even if bus is not hot-pluggable, devices can be unbound from the
> > driver via sysfs, so we should not be using __exit annotations on
> > remove() methods. The only exception is drivers registered with
> > platform_driver_probe() which specifically disables sysfs bind/unbind
> > attributes.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Patch queued for 4.12, thanks.
>
> It seems that there are still some fbdev drivers with this issue:
I do not think so:
>
> $ git grep __exit_p drivers/video/fbdev/
> drivers/video/fbdev/amifb.c: .remove = __exit_p(amifb_remove),
Registered as module_platform_driver_probe(), which ends up suppressing
sysfs bind/unbind attributes.
> drivers/video/fbdev/atmel_lcdfb.c: .remove = __exit_p(atmel_lcdfb_remove),
Registered as module_platform_driver_probe(), which ends up suppressing
sysfs bind/unbind attributes.
> drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c: .remove = __exit_p(tvc_remove),
> drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c: .remove = __exit_p(dvic_remove),
> drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c: .remove = __exit_p(hdmic_remove),
> drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: .remove = __exit_p(opa362_remove),
> drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: .remove = __exit_p(tfp410_remove),
> drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c: .remove = __exit_p(tpd_remove),
> drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: .remove = __exit_p(panel_dpi_remove),
> drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c: .remove = __exit_p(dsicm_remove),
> drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c: .remove = __exit_p(sharp_ls_remove),
As far as I can see all omapfb/displays/ drivers explicitly disable
bind/unbind attributes by setting:
.suppress_bind_attrs = true,
> drivers/video/fbdev/omap2/omapfb/vrfb.c: .remove = __exit_p(vrfb_remove),
Registered as module_platform_driver_probe(), which ends up suppressing
sysfs bind/unbind attributes.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2017-03-20 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170302013109epcas3p3ae90f60d7aa8f14bb09eb5ec342cfaeb@epcas3p3.samsung.com>
2017-03-02 1:31 ` [PATCH] video: fbdev: i810: remove incorrect __exit markups Dmitry Torokhov
2017-03-20 17:19 ` Bartlomiej Zolnierkiewicz
2017-03-20 18:42 ` Dmitry Torokhov [this message]
2017-03-20 18:54 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320184256.GB23083@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=adaplas@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).